[PATCH] D96009: [clangd] Improve name conflict detection

2021-02-04 Thread Kirill Bobyrev via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe8a2b7c91563: [clangd] Improve name conflict detection (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D96009: [clangd] Improve name conflict detection

2021-02-04 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev updated this revision to Diff 321545. kbobyrev added a comment. Can't instantiate DynTypedNode with FunctionProtoTypeLoc, has to be just TypeLoc :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96009/new/ https://reviews.llvm.org/D96009

[PATCH] D96009: [clangd] Improve name conflict detection

2021-02-04 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev updated this revision to Diff 321398. kbobyrev marked an inline comment as done. kbobyrev added a comment. Use FunctionProtoTypeLoc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96009/new/ https://reviews.llvm.org/D96009 Files: clang-to

[PATCH] D96009: [clangd] Improve name conflict detection

2021-02-04 Thread Haojian Wu via Phabricator via cfe-commits
hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:343 const auto *Parent = GetSingleParent(DynTypedNode::create(RenamedDecl)); - if (!Parent || !Parent->ge

[PATCH] D96009: [clangd] Improve name conflict detection

2021-02-04 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev created this revision. kbobyrev added a reviewer: hokein. Herald added subscribers: usaxena95, kadircet, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Follow-up on D95925