[PATCH] D96114: [ASTMatchers] Fix parent-child traversal between functions and parms

2021-02-28 Thread Stephen Kelly via Phabricator via cfe-commits
steveire abandoned this revision. steveire added a comment. Clearing this out of my outgoing list. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96114/new/ https://reviews.llvm.org/D96114 ___

[PATCH] D96114: [ASTMatchers] Fix parent-child traversal between functions and parms

2021-02-22 Thread Stephen Kelly via Phabricator via cfe-commits
steveire added a comment. In D96114#2548029 , @klimek wrote: > Can you explain the change and the before/after a bit more? Thanks! I'm not sure. Can you ask a more-specific question? Did you read the link that Nathan posted? Is the unit test unclear?

[PATCH] D96114: [ASTMatchers] Fix parent-child traversal between functions and parms

2021-02-08 Thread Manuel Klimek via Phabricator via cfe-commits
klimek added a comment. Can you explain the change and the before/after a bit more? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96114/new/ https://reviews.llvm.org/D96114 ___ cfe-commits

[PATCH] D96114: [ASTMatchers] Fix parent-child traversal between functions and parms

2021-02-07 Thread Stephen Kelly via Phabricator via cfe-commits
steveire updated this revision to Diff 321991. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96114/new/ https://reviews.llvm.org/D96114 Files: clang/include/clang/AST/RecursiveASTVisitor.h

[PATCH] D96114: [ASTMatchers] Fix parent-child traversal between functions and parms

2021-02-06 Thread Nathan James via Phabricator via cfe-commits
njames93 added a reviewer: klimek. njames93 added a comment. I have no issues here, but see what the others say as well. Also related post to cfe-dev - https://lists.llvm.org/pipermail/cfe-dev/2021-February/067629.html Comment at:

[PATCH] D96114: [ASTMatchers] Fix parent-child traversal between functions and parms

2021-02-05 Thread Stephen Kelly via Phabricator via cfe-commits
steveire created this revision. steveire added reviewers: aaron.ballman, njames93. Herald added a subscriber: kristof.beyls. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Having to match on the typeLoc in AsIs mode is