[PATCH] D96215: [clang-tidy] Aliasing: Add support for lambda captures.

NoQ added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/Aliasing.cpp:45-48 +return llvm::any_of(LE->captures(), [Var](const LambdaCapture ) { + return C.capturesVariable() && C.getCaptureKind() == LCK_ByRef && + C.getCapturedVar() == Var; +

[PATCH] D96215: [clang-tidy] Aliasing: Add support for lambda captures.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG43f4331edfb5: [clang-tidy] Aliasing: Add support for captures. (authored by dergachev.a). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D96215: [clang-tidy] Aliasing: Add support for lambda captures.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang-tools-extra/clang-tidy/utils/Aliasing.cpp:45-48 +return llvm::any_of(LE->captures(), [Var](const LambdaCapture ) { + return

[PATCH] D96215: [clang-tidy] Aliasing: Add support for lambda captures.

NoQ added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/Aliasing.cpp:45-48 +return llvm::any_of(LE->captures(), [Var](const LambdaCapture ) { + return C.capturesVariable() && C.getCaptureKind() == LCK_ByRef && + C.getCapturedVar() == Var; +

[PATCH] D96215: [clang-tidy] Aliasing: Add support for lambda captures.

aaron.ballman added a comment. In D96215#2737085 , @NoQ wrote: > In D96215#2735546 , @njames93 wrote: > >> Just my $0.02, We shouldn't worry too much about pathological cases like >> that. I imagine that code

[PATCH] D96215: [clang-tidy] Aliasing: Add support for lambda captures.

NoQ added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/Aliasing.cpp:45 +// Treat lambda capture by reference as a form of taking a reference. +return llvm::any_of(LE->captures(), [Var](const LambdaCapture ) { + return C.capturesVariable() &&

[PATCH] D96215: [clang-tidy] Aliasing: Add support for lambda captures.

xazax.hun added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/Aliasing.cpp:45 +// Treat lambda capture by reference as a form of taking a reference. +return llvm::any_of(LE->captures(), [Var](const LambdaCapture ) { + return C.capturesVariable() &&

[PATCH] D96215: [clang-tidy] Aliasing: Add support for lambda captures.

NoQ added a comment. In D96215#2735546 , @njames93 wrote: > Just my $0.02, We shouldn't worry too much about pathological cases like > that. I imagine that code would almost never appear in the wild. And for > cases where you don't have access to

[PATCH] D96215: [clang-tidy] Aliasing: Add support for lambda captures.

NoQ updated this revision to Diff 342844. NoQ added a comment. Unforget to add `-fblocks` to the bugprone-redundant-branch-condition checks. Thanks pre-commit testing! - it wasn't failing on my machine, I guess it's enabled by default on darwin. CHANGES SINCE LAST ACTION

[PATCH] D96215: [clang-tidy] Aliasing: Add support for lambda captures.

njames93 added a comment. In D96215#2550227 , @NoQ wrote: > Umm, looks like we're both missing the elephant in the room: passing a > variable into a function by reference. > > int _reference(int ) { > return x; > } > > void

[PATCH] D96215: [clang-tidy] Aliasing: Add support for lambda captures.

xazax.hun added a comment. Don't mind my previous comment :) I missed the conversation about function by-ref arguments. :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96215/new/ https://reviews.llvm.org/D96215 ___ cfe-commits mailing list

[PATCH] D96215: [clang-tidy] Aliasing: Add support for lambda captures.

xazax.hun added a comment. > I'm arguing that it should scan for lambda captures by reference as well. What about immediately invoked lambdas? Would it make sense to exclude those? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96215/new/ https://reviews.llvm.org/D96215

[PATCH] D96215: [clang-tidy] Aliasing: Add support for lambda captures.

NoQ added a comment. I covered pass-by-reference-into-function in D101790 and decomposition (from a certain point of view) in D101791 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96215/new/

[PATCH] D96215: [clang-tidy] Aliasing: Add support for lambda captures.

NoQ updated this revision to Diff 342550. NoQ retitled this revision from "[clang-tidy] Recognize captures as a form of aliasing." to "[clang-tidy] Aliasing: Add support for lambda captures.". NoQ added a comment. Herald added a project: clang-tools-extra. Trivial rebase. CHANGES SINCE LAST