[PATCH] D96280: [clang][cli] Round-trip the whole CompilerInvocation

alanphipps added a comment. In D96280#2611651 , @alanphipps wrote: > We also encounter a build failure on the Mac related to above but in a > different file: > clang/lib/CodeGen/CGStmtOpenMP.cpp:1916:3: error: too few template arguments > for class templ

[PATCH] D96280: [clang][cli] Round-trip the whole CompilerInvocation

alanphipps added a comment. We also encounter a build failure on the Mac related to above but in a different file: clang/lib/CodeGen/CGStmtOpenMP.cpp:1916:3: error: too few template arguments for class template 'SmallVector' SmallVector EffectiveArgs; ^ clang/include/clang/Basic/LLVM.h:35:42: no

[PATCH] D96280: [clang][cli] Round-trip the whole CompilerInvocation

scui added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:666 + // semantics as the original. + SmallVector GeneratedArgs1; + Generate(DummyInvocation, GeneratedArgs1, SA); jansvoboda11 wrote: > scui wrote: > > This is failing our build

[PATCH] D96280: [clang][cli] Round-trip the whole CompilerInvocation

jansvoboda11 added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:666 + // semantics as the original. + SmallVector GeneratedArgs1; + Generate(DummyInvocation, GeneratedArgs1, SA); scui wrote: > This is failing our build, This line and

[PATCH] D96280: [clang][cli] Round-trip the whole CompilerInvocation

scui added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:666 + // semantics as the original. + SmallVector GeneratedArgs1; + Generate(DummyInvocation, GeneratedArgs1, SA); This is failing our build, This line and line 686. The msg is:

[PATCH] D96280: [clang][cli] Round-trip the whole CompilerInvocation

This revision was automatically updated to reflect the committed changes. Closed by commit rGd748908fa02b: [clang][cli] Round-trip the whole CompilerInvocation (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96280/new/ http

[PATCH] D96280: [clang][cli] Round-trip the whole CompilerInvocation

jansvoboda11 updated this revision to Diff 324933. jansvoboda11 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96280/new/ https://reviews.llvm.org/D96280 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/in

[PATCH] D96280: [clang][cli] Round-trip the whole CompilerInvocation

jansvoboda11 updated this revision to Diff 324229. jansvoboda11 added a comment. Add fixme as suggested in code review. Rebase on top of the final version of D94472 , which added `-[no-]round-trip-args`. The arguments are now handled in `RoundTrip`. Repository:

[PATCH] D96280: [clang][cli] Round-trip the whole CompilerInvocation

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM! One more more comment inline. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:4534-4547 + InputKind DashX = FrontendOpts.DashX; + if (DashX.getFormat()

[PATCH] D96280: [clang][cli] Round-trip the whole CompilerInvocation

jansvoboda11 added a comment. Updated the patch, removed `[WIP]` from the title and replied to comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1940-1941 case EDK_ProfileList: - GenerateArg(Args, OPT_fprofile_list_EQ, Dep.first, SA); + // Generated