This revision was automatically updated to reflect the committed changes.
Closed by commit rG438b5bb05a42: [clangd] Use ML Code completion ranking as
default. (authored by usaxena95).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96353/new/
https://
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
maybe add some data (improvement DecisionForest vs heuristic) in the patch
description.
Comment at: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp:651
+ auto Resu
usaxena95 added inline comments.
Comment at: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp:651
+ auto Results =
+ completions("int main() { abs^ }", {func("absl"), func("absb")});
EXPECT_THAT(Results.Completions,
hokein wrote:
> sorry, I didn'
usaxena95 updated this revision to Diff 322922.
usaxena95 marked 2 inline comments as done.
usaxena95 added a comment.
Addressed comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96353/new/
https://reviews.llvm.org/D96353
Files:
clang-tool
hokein added inline comments.
Comment at: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp:651
+ auto Results =
+ completions("int main() { abs^ }", {func("absl"), func("absb")});
EXPECT_THAT(Results.Completions,
sorry, I didn't infer the motivat
usaxena95 created this revision.
usaxena95 added a reviewer: hokein.
Herald added subscribers: kadircet, arphaman.
usaxena95 requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang.
Also treat Keywords separately as they are n
