[PATCH] D96404: [Android] Default to --rtlib=compiler-rt

2021-03-10 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai added a comment. Hilariously enough, this breaks building compiler-rt itself inside LLVM's runtime builds setup for us. The runtimes build setup builds clang and then uses the just-built clang to build compiler-rt. That build fails to link since my just-built clang doesn't have compiler

[PATCH] D96404: [Android] Default to --rtlib=compiler-rt

2021-03-09 Thread Ryan Prichard via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa478b0a199f4: [Android] Default to --rtlib=compiler-rt (authored by rprichard). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D96404: [Android] Default to --rtlib=compiler-rt

2021-03-09 Thread Ryan Prichard via Phabricator via cfe-commits
rprichard updated this revision to Diff 329475. rprichard added a comment. Rebase this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96404/new/ https://reviews.llvm.org/D96404 Files: clang/lib/Driver/ToolChains/Linux.cpp clang/lib/Dr

[PATCH] D96404: [Android] Default to --rtlib=compiler-rt

2021-02-10 Thread Ryan Prichard via Phabricator via cfe-commits
rprichard added reviewers: danalbert, srhines, pcc. rprichard added subscribers: thakis, glandium. rprichard added a comment. Adding glandium and thakis for Firefox and Chrome. e.g. I suspect this change would cause the same sort of breakage seen in D95166 . Re

[PATCH] D96404: [Android] Default to --rtlib=compiler-rt

2021-02-10 Thread Ryan Prichard via Phabricator via cfe-commits
rprichard created this revision. Herald added a subscriber: dberris. rprichard requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. By default, the driver uses the compiler-rt builtins and links with -l:libunwind.a. Restore the previous behavio