[PATCH] D96419: [clang] Add -ffinite-loops & -fno-finite-loops options.

fhahn added a comment. In D96419#2556411 , @xbolva00 wrote: > In D96419#2556349 , @fhahn wrote: > >> In D96419#213 , @xbolva00 wrote: >> >>> Maybe we want these options

[PATCH] D96419: [clang] Add -ffinite-loops & -fno-finite-loops options.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG51bf4c0e6d4c: [clang] Add -ffinite-loops -fno-finite-loops options. (authored by fhahn). Changed prior to commit:

[PATCH] D96419: [clang] Add -ffinite-loops & -fno-finite-loops options.

fhahn updated this revision to Diff 323373. fhahn added a comment. Rebased the patch to apply wihtout D96418 . Will land soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96419/new/

[PATCH] D96419: [clang] Add -ffinite-loops & -fno-finite-loops options.

xbolva00 added a comment. In D96419#2556349 , @fhahn wrote: > In D96419#213 , @xbolva00 wrote: > >> Maybe we want these options in llvm 12 as well? >> >> (+ Release note) > > That's a good idea. The patch

[PATCH] D96419: [clang] Add -ffinite-loops & -fno-finite-loops options.

fhahn added a comment. In D96419#213 , @xbolva00 wrote: > Maybe we want these options in llvm 12 as well? > > (+ Release note) That's a good idea. The patch currently depends on D96418 . Not sure if we should pull

[PATCH] D96419: [clang] Add -ffinite-loops & -fno-finite-loops options.

xbolva00 added a comment. Maybe we want these options in llvm 12 as well? (+ Release note) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96419/new/ https://reviews.llvm.org/D96419 ___ cfe-commits

[PATCH] D96419: [clang] Add -ffinite-loops & -fno-finite-loops options.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96419/new/ https://reviews.llvm.org/D96419

[PATCH] D96419: [clang] Add -ffinite-loops & -fno-finite-loops options.

fhahn added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.h:147 +No = 2, // No loop is assumed to be finite. + }; + jdoerfert wrote: > Can we have different names? > > `FiniteLoopsKind::None` sounds more like what

[PATCH] D96419: [clang] Add -ffinite-loops & -fno-finite-loops options.

fhahn updated this revision to Diff 322803. fhahn added a comment. adjust naming of enum members as suggested, thanks! I think it cannot be an enum class unfortunately because the CodeGenOption machinery seems to use regular enums/unsigneds. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D96419: [clang] Add -ffinite-loops & -fno-finite-loops options.

jdoerfert added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.h:147 +No = 2, // No loop is assumed to be finite. + }; + Can we have different names? `FiniteLoopsKind::None` sounds more like what ``FiniteLoopsKind::No` implies.

[PATCH] D96419: [clang] Add -ffinite-loops & -fno-finite-loops options.

fhahn added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1923 + if (Arg *A = Args.getLastArg(OPT_save_temps_EQ)) +Opts.SaveTempsFilePrefix = xbolva00 wrote: > Not needed Removed, thanks! Repository: rG LLVM Github Monorepo

[PATCH] D96419: [clang] Add -ffinite-loops & -fno-finite-loops options.

fhahn updated this revision to Diff 322683. fhahn added a comment. Remove accidentally copied code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96419/new/ https://reviews.llvm.org/D96419 Files: clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D96419: [clang] Add -ffinite-loops & -fno-finite-loops options.

xbolva00 added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1923 + if (Arg *A = Args.getLastArg(OPT_save_temps_EQ)) +Opts.SaveTempsFilePrefix = Not needed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D96419: [clang] Add -ffinite-loops & -fno-finite-loops options.

fhahn updated this revision to Diff 322679. fhahn added a comment. Add description for options. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96419/new/ https://reviews.llvm.org/D96419 Files: clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D96419: [clang] Add -ffinite-loops & -fno-finite-loops options.

fhahn created this revision. fhahn added reviewers: jdoerfert, rjmccall, xbolva00, atmnpatel, aaron.ballman, rsmith. Herald added subscribers: dexonsmith, dang. Herald added a reviewer: jansvoboda11. fhahn requested review of this revision. Herald added a project: clang. Herald added a