[PATCH] D96760: [clang-format] Suppress diagnostics on second parse

This revision was automatically updated to reflect the committed changes. Closed by commit rGe7309404536c: [clang-format] Suppress diagnostics on second parse (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96760/new/

[PATCH] D96760: [clang-format] Suppress diagnostics on second parse

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96760/new/ https://reviews.llvm.org/D96760 _

[PATCH] D96760: [clang-format] Suppress diagnostics on second parse

njames93 added a comment. LGTM, but see what @MyDeveloperDay has to say. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96760/new/ https://reviews.llvm.org/D96760 ___ cfe-commits mailing list cfe-commits@

[PATCH] D96760: [clang-format] Suppress diagnostics on second parse

HazardyKnusperkeks updated this revision to Diff 328075. HazardyKnusperkeks added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96760/new/ https://reviews.llvm.org/D96760 Files: clang/include/clang/Format/Format.h clang/lib

[PATCH] D96760: [clang-format] Suppress diagnostics on second parse

HazardyKnusperkeks added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96760/new/ https://reviews.llvm.org/D96760 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D96760: [clang-format] Suppress diagnostics on second parse

njames93 added a comment. In D96760#2569151 , @HazardyKnusperkeks wrote: > In D96760#2565171 , @njames93 wrote: > >> I did have another plan for a different way to go about this, not sure if >> its really any bett

[PATCH] D96760: [clang-format] Suppress diagnostics on second parse

HazardyKnusperkeks updated this revision to Diff 324407. HazardyKnusperkeks marked an inline comment as done. HazardyKnusperkeks added a comment. Added DiagHandlerCtxt. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96760/new/ https://reviews.llvm.o

[PATCH] D96760: [clang-format] Suppress diagnostics on second parse

HazardyKnusperkeks added a comment. In D96760#2565171 , @njames93 wrote: > I did have another plan for a different way to go about this, not sure if its > really any better though. > It involved building a vector of the edits the config would apply to its

[PATCH] D96760: [clang-format] Suppress diagnostics on second parse

njames93 added a comment. I did have another plan for a different way to go about this, not sure if its really any better though. It involved building a vector of the edits the config would apply to its parent. Then after the parent is parsed just applying those edits. It results in only 1 pass

[PATCH] D96760: [clang-format] Suppress diagnostics on second parse

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:3342-3346 inline std::error_code parseConfiguration(StringRef Config, FormatStyle *Style, bool AllowUnknownOptions = false) { return parseConfi

[PATCH] D96760: [clang-format] Suppress diagnostics on second parse

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: njames93, MyDeveloperDay, curdeius. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is t