[PATCH] D96783: [Driver] Support -gdwarf64 for assembly files

2021-02-17 Thread Igor Kudrin via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. ikudrin marked 2 inline comments as done. Closed by commit rG72eee60b2451: [Driver] Support -gdwarf64 for assembly files (authored by ikudrin). Changed prior to commit: https://reviews.llvm.org/D96783?vs=323989&id=324239#

[PATCH] D96783: [Driver] Support -gdwarf64 for assembly files

2021-02-16 Thread Igor Kudrin via Phabricator via cfe-commits
ikudrin marked 2 inline comments as done. ikudrin added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3757-3771 + if (DwarfFormatArg && + DwarfFormatArg->getOption().matches(options::OPT_gdwarf64)) { +if (DwarfVersion < 3) + D.Diag(diag::err_dr

[PATCH] D96783: [Driver] Support -gdwarf64 for assembly files

2021-02-16 Thread Alexander Yermolovich via Phabricator via cfe-commits
ayermolo added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96783/new/ https://reviews.llvm.org/D96783 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D96783: [Driver] Support -gdwarf64 for assembly files

2021-02-16 Thread David Blaikie via Phabricator via cfe-commits
dblaikie accepted this revision. dblaikie added a comment. Looks good to me - thanks Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3757-3771 + if (DwarfFormatArg && + DwarfFormatArg->getOption().matches(options::OPT_gdwarf64)) { +if (DwarfVersion < 3) + D.Dia

[PATCH] D96783: [Driver] Support -gdwarf64 for assembly files

2021-02-16 Thread Igor Kudrin via Phabricator via cfe-commits
ikudrin created this revision. ikudrin added reviewers: ayermolo, dblaikie, aprantl, MaskRay. ikudrin added projects: LLVM, clang, debug-info. Herald added subscribers: jansvoboda11, dang. ikudrin requested review of this revision. The option was added in D90507 f