[PATCH] D96825: [AArch64] Adding Polynomial vadd Intrinsics support

2021-02-17 Thread Ryan Santhirarajan via Phabricator via cfe-commits
rsanthir.quic marked an inline comment as done. rsanthir.quic added inline comments. Comment at: clang/test/CodeGen/aarch64-poly-add.c:4 +// RUN: %clang_cc1 -triple arm64-none-linux-gnu -target-feature +neon \ +// RUN: -disable-O0-optnone -ffp-contract=fast -emit-llvm -o - %s | o

[PATCH] D96825: [AArch64] Adding Polynomial vadd Intrinsics support

2021-02-17 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett added a comment. This LGTM unless @labrinea has any final comments. Could you add "Neon" in the commit title? "[AArch64] Adding Neon Polynomial vadd Intrinsics support", just to help when reading git history. Comment at: clang/test/CodeGen/aarch64-poly-add.c:4 +

[PATCH] D96825: [AArch64] Adding Polynomial vadd Intrinsics support

2021-02-17 Thread Tim Northover via Phabricator via cfe-commits
t.p.northover accepted this revision. t.p.northover added a comment. This revision is now accepted and ready to land. Looks sensible to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96825/new/ https://reviews.llvm.org/D96825 ___ cfe-commi

[PATCH] D96825: [AArch64] Adding Polynomial vadd Intrinsics support

2021-02-16 Thread Ryan Santhirarajan via Phabricator via cfe-commits
rsanthir.quic updated this revision to Diff 324153. rsanthir.quic added a comment. rebased due to merge issues CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96825/new/ https://reviews.llvm.org/D96825 Files: clang/include/clang/Basic/arm_neon.td clang/lib/CodeGen/CGBuiltin.cpp cla

[PATCH] D96825: [AArch64] Adding Polynomial vadd Intrinsics support

2021-02-16 Thread Ryan Santhirarajan via Phabricator via cfe-commits
rsanthir.quic added a comment. This is the final of three patches to address the following: https://bugs.llvm.org/show_bug.cgi?id=47828 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96825/new/ https://reviews.llvm.org/D96825 __

[PATCH] D96825: [AArch64] Adding Polynomial vadd Intrinsics support

2021-02-16 Thread Ryan Santhirarajan via Phabricator via cfe-commits
rsanthir.quic created this revision. rsanthir.quic added reviewers: t.p.northover, kevin.qin, labrinea, pbarrio, apazos. Herald added subscribers: danielkiss, kristof.beyls. rsanthir.quic requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Thi