[PATCH] D96877: [libomptarget] Try a fallback devicertl if the preferred one is missing

JonChesterfield abandoned this revision. JonChesterfield added a comment. I'm going to abandon this. I'm not confident that a cuda toolkit that is newer than the compiler will work with it correctly and would prefer it take some jury rigging on the end users part to put the two together. I get

[PATCH] D96877: [libomptarget] Try a fallback devicertl if the preferred one is missing

tianshilei1992 added a comment. In D96877#2578756 , @ye-luo wrote: > In D96877#2578752 , @tianshilei1992 > wrote: > >> In D96877#2578748 , @ye-luo wrote: >> >>> to me this

[PATCH] D96877: [libomptarget] Try a fallback devicertl if the preferred one is missing

ye-luo added a comment. In D96877#2578752 , @tianshilei1992 wrote: > In D96877#2578748 , @ye-luo wrote: > >> to me this is still desired + cmake creating libomptarget-nvptx-unknown.bc >> as a solution for forward

[PATCH] D96877: [libomptarget] Try a fallback devicertl if the preferred one is missing

tianshilei1992 added a comment. In D96877#2578748 , @ye-luo wrote: > to me this is still desired + cmake creating libomptarget-nvptx-unknown.bc as > a solution for forward compatibility until a clean solution lands. We’ll have newer version LLVM like

[PATCH] D96877: [libomptarget] Try a fallback devicertl if the preferred one is missing

ye-luo added a comment. to me this is still desired + cmake creating libomptarget-nvptx-unknown.bc as a solution for forward compatibility until a clean solution lands. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96877/new/

[PATCH] D96877: [libomptarget] Try a fallback devicertl if the preferred one is missing

tianshilei1992 added a comment. I think we might not this patch. We’re gonna not support old version of CUDA anyway. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96877/new/ https://reviews.llvm.org/D96877

[PATCH] D96877: [libomptarget] Try a fallback devicertl if the preferred one is missing

JonChesterfield added a comment. Is this obsolete with the change to devicertl cmake? Would prefer abandon to land if so Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96877/new/ https://reviews.llvm.org/D96877

[PATCH] D96877: [libomptarget] Try a fallback devicertl if the preferred one is missing

ye-luo accepted this revision. ye-luo added a comment. This revision is now accepted and ready to land. Got it. Copy a file can be tricky. Compile one more can be easily done in cmake. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96877/new/

[PATCH] D96877: [libomptarget] Try a fallback devicertl if the preferred one is missing

ye-luo requested changes to this revision. ye-luo added a comment. This revision now requires changes to proceed. Let user to copy the bc file is not feasible. Handle this in CMake please. libomptarget-nvptx-unknown.bc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D96877: [libomptarget] Try a fallback devicertl if the preferred one is missing

JonChesterfield added a comment. Which tests? Choosing a file to duplicate with the unknown.bc name is left separate. This just adds code to look for that file if the first choice failed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96877/new/

[PATCH] D96877: [libomptarget] Try a fallback devicertl if the preferred one is missing

tianshilei1992 accepted this revision. tianshilei1992 added a comment. This revision is now accepted and ready to land. LGTM. Please also update the test(s) before commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96877/new/

[PATCH] D96877: [libomptarget] Try a fallback devicertl if the preferred one is missing

ye-luo added a comment. Does this patch includes creating 'libomptarget-nvptx-unknown.bc'? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96877/new/ https://reviews.llvm.org/D96877 ___ cfe-commits

[PATCH] D96877: [libomptarget] Try a fallback devicertl if the preferred one is missing

JonChesterfield added a comment. If you like it, accept it. If there's more stuff to do first, please say so. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96877/new/ https://reviews.llvm.org/D96877 ___

[PATCH] D96877: [libomptarget] Try a fallback devicertl if the preferred one is missing

jdoerfert added a comment. Can we wrap this up and backport it, last known issue we should fix for 12. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96877/new/ https://reviews.llvm.org/D96877 ___

[PATCH] D96877: [libomptarget] Try a fallback devicertl if the preferred one is missing

JonChesterfield added a comment. In D96877#2569863 , @tianshilei1992 wrote: > Please also update the test. > > In D96877#2569861 , @JonChesterfield > wrote: > >> Suggestion is to resolve

[PATCH] D96877: [libomptarget] Try a fallback devicertl if the preferred one is missing

JonChesterfield updated this revision to Diff 32. JonChesterfield added a comment. - address review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96877/new/ https://reviews.llvm.org/D96877 Files:

[PATCH] D96877: [libomptarget] Try a fallback devicertl if the preferred one is missing

tianshilei1992 added a comment. Please also update the test. In D96877#2569861 , @JonChesterfield wrote: > Suggestion is to resolve libomptarget-nvptx-unknown.bc to a cp of the bitcode > libary built for the newest sm_xx and ptx version clang knows of.

[PATCH] D96877: [libomptarget] Try a fallback devicertl if the preferred one is missing

tianshilei1992 added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:265 "No library '%0' found in the default clang lib directory or in LIBRARY_PATH. Please use --libomptarget-%1-bc-path to specify %1 bitcode library.">; +def

[PATCH] D96877: [libomptarget] Try a fallback devicertl if the preferred one is missing

JonChesterfield added a comment. Suggestion is to resolve libomptarget-nvptx-unknown.bc to a cp of the bitcode libary built for the newest sm_xx and ptx version clang knows of. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96877/new/

[PATCH] D96877: [libomptarget] Try a fallback devicertl if the preferred one is missing

JonChesterfield added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:265 "No library '%0' found in the default clang lib directory or in LIBRARY_PATH. Please use --libomptarget-%1-bc-path to specify %1 bitcode library.">; +def

[PATCH] D96877: [libomptarget] Try a fallback devicertl if the preferred one is missing

JonChesterfield marked an inline comment as done. JonChesterfield added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1647 +llvm::Twine lib) { + for (StringRef LibraryPath : LibraryPaths) { +SmallString<128> TargetFile(LibraryPath);

[PATCH] D96877: [libomptarget] Try a fallback devicertl if the preferred one is missing

JonChesterfield updated this revision to Diff 324354. JonChesterfield added a comment. - review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96877/new/ https://reviews.llvm.org/D96877 Files:

[PATCH] D96877: [libomptarget] Try a fallback devicertl if the preferred one is missing

tianshilei1992 added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:265 "No library '%0' found in the default clang lib directory or in LIBRARY_PATH. Please use --libomptarget-%1-bc-path to specify %1 bitcode library.">; +def

[PATCH] D96877: [libomptarget] Try a fallback devicertl if the preferred one is missing

tianshilei1992 added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1695 -std::string LibOmpTargetName = -"libomptarget-" + BitcodeSuffix.str() + ".bc"; - -for (StringRef LibraryPath : LibraryPaths) { - SmallString<128>

[PATCH] D96877: [libomptarget] Try a fallback devicertl if the preferred one is missing

JonChesterfield updated this revision to Diff 324342. JonChesterfield added a comment. - drop whitespace from .td Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96877/new/ https://reviews.llvm.org/D96877 Files:

[PATCH] D96877: [libomptarget] Try a fallback devicertl if the preferred one is missing

JonChesterfield created this revision. JonChesterfield added reviewers: jdoerfert, ye-luo, tianshilei1992, ABataev, grokos. JonChesterfield requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. [libomptarget] Try a fallback devicertl