[PATCH] D97009: [CUDA] fix builtin constraints for PTX 7.2

2021-02-19 Thread Jordan Rupprecht via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG1a368ae3b78d: [CUDA] fix builtin constraints for PTX 7.2 (authored by tra, committed by rupprecht). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97009/new/

[PATCH] D97009: [CUDA] fix builtin constraints for PTX 7.2

2021-02-19 Thread Jordan Rupprecht via Phabricator via cfe-commits
rupprecht added a comment. This fixes a build error we're seeing, so I'd like to land this in a bit if that's OK. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97009/new/ https://reviews.llvm.org/D97009 ___

[PATCH] D97009: [CUDA] fix builtin constraints for PTX 7.2

2021-02-18 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97009/new/ https://reviews.llvm.org/D97009

[PATCH] D97009: [CUDA] fix builtin constraints for PTX 7.2

2021-02-18 Thread Artem Belevich via Phabricator via cfe-commits
tra marked an inline comment as done. tra added inline comments. Comment at: clang/include/clang/Basic/BuiltinsNVPTX.def:744 #pragma pop_macro("PTX70") #pragma pop_macro("PTX71") yaxunl wrote: > need to pop PTX72 ? Good catch. Done. Repository: rG LLVM Gith

[PATCH] D97009: [CUDA] fix builtin constraints for PTX 7.2

2021-02-18 Thread Artem Belevich via Phabricator via cfe-commits
tra updated this revision to Diff 324829. tra added a comment. pop the macro Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97009/new/ https://reviews.llvm.org/D97009 Files: clang/include/clang/Basic/BuiltinsNVPTX.def clang/test/CodeGen/builtin

[PATCH] D97009: [CUDA] fix builtin constraints for PTX 7.2

2021-02-18 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added inline comments. Comment at: clang/include/clang/Basic/BuiltinsNVPTX.def:744 #pragma pop_macro("PTX70") #pragma pop_macro("PTX71") need to pop PTX72 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97

[PATCH] D97009: [CUDA] fix builtin constraints for PTX 7.2

2021-02-18 Thread Artem Belevich via Phabricator via cfe-commits
tra updated this revision to Diff 324812. tra edited the summary of this revision. tra added a comment. Updated the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97009/new/ https://reviews.llvm.org/D97009 Files: clang/include/clang/Basic/B

[PATCH] D97009: [CUDA] fix builtin constraints for PTX 7.2

2021-02-18 Thread Artem Belevich via Phabricator via cfe-commits
tra created this revision. tra added a reviewer: yaxunl. Herald added subscribers: bixia, jholewinski. tra requested review of this revision. Herald added a project: clang. This fixes build issues w/ CUDA-11 introduced by https://reviews.llvm.org/D95974 Repository: rG LLVM Github Monorepo htt