[PATCH] D97098: [Utils] Add an option to specify number of cores to use in creduce-clang-crash.py

This revision was automatically updated to reflect the committed changes. Closed by commit rGb380699416d8: [Utils] Add an option to specify number of cores to use in creduce-clang-crash. (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D97098: [Utils] Add an option to specify number of cores to use in creduce-clang-crash.py

rnk accepted this revision. rnk added a comment. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97098/new/ https://reviews.llvm.org/D97098 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D97098: [Utils] Add an option to specify number of cores to use in creduce-clang-crash.py

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. But lgtm either way. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97098/new/ https://reviews.llvm.org/D97098 _

[PATCH] D97098: [Utils] Add an option to specify number of cores to use in creduce-clang-crash.py

thakis added a comment. In D97098#2579620 , @zequanwu wrote: > Address comment, using `max(4, multiprocessing.cpu_count() / 2)` because > `os.cpu_count` is not available in python2. We require py3 these days, so it's ok to assume it. Repository: rG L

[PATCH] D97098: [Utils] Add an option to specify number of cores to use in creduce-clang-crash.py

zequanwu updated this revision to Diff 325520. zequanwu added a comment. Address comment, using `max(4, multiprocessing.cpu_count() / 2)` because `os.cpu_count` is not available in python2. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97098/new/

[PATCH] D97098: [Utils] Add an option to specify number of cores to use in creduce-clang-crash.py

rnk added inline comments. Comment at: clang/utils/creduce-clang-crash.py:81 self.creduce_flags = ["--tidy"] +if core_number > 0: + self.creduce_flags = ["--n", str(core_number)] I think we should try to pick a good default here. I think we can do b

[PATCH] D97098: [Utils] Add an option to specify number of cores to use in creduce-clang-crash.py

zequanwu created this revision. zequanwu added reviewers: akhuang, thakis, rnk. zequanwu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D97098 Files: clang/utils/creduce-cl