[PATCH] D97116: Reduce the number of attributes attached to each function

2021-04-08 Thread Dávid Bolvanský via Phabricator via cfe-commits
xbolva00 added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:496 //function. - CurFn->addFnAttr("min-legal-vector-width", llvm::utostr(LargestVectorWidth)); + if (LargestVectorWidth) +CurFn->addFnAttr("min-legal-vector-width", llvm::utostr(Large

[PATCH] D97116: Reduce the number of attributes attached to each function

2021-04-08 Thread Wei Xiao via Phabricator via cfe-commits
wxiao3 added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:496 //function. - CurFn->addFnAttr("min-legal-vector-width", llvm::utostr(LargestVectorWidth)); + if (LargestVectorWidth) +CurFn->addFnAttr("min-legal-vector-width", llvm::utostr(Largest

[PATCH] D97116: Reduce the number of attributes attached to each function

2021-04-08 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:496 //function. - CurFn->addFnAttr("min-legal-vector-width", llvm::utostr(LargestVectorWidth)); + if (LargestVectorWidth) +CurFn->addFnAttr("min-legal-vector-width", llvm::utostr(Lar

[PATCH] D97116: Reduce the number of attributes attached to each function

2021-04-08 Thread Wei Xiao via Phabricator via cfe-commits
wxiao3 added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:496 //function. - CurFn->addFnAttr("min-legal-vector-width", llvm::utostr(LargestVectorWidth)); + if (LargestVectorWidth) +CurFn->addFnAttr("min-legal-vector-width", llvm::utostr(Largest

[PATCH] D97116: Reduce the number of attributes attached to each function

2021-03-08 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. In D97116#2610652 , @crownyanguan wrote: > In D97116#2596409 , @xbolva00 wrote: > >> In D97116#2596275 , @crownyanguan >> wrote: >> >>> However,

[PATCH] D97116: Reduce the number of attributes attached to each function

2021-03-08 Thread crownyanguan via Phabricator via cfe-commits
crownyanguan added a comment. In D97116#2596409 , @xbolva00 wrote: > In D97116#2596275 , @crownyanguan > wrote: > >> However, this commit will cause performance regression. > > More details? This commit will decre

[PATCH] D97116: Reduce the number of attributes attached to each function

2021-03-01 Thread Dávid Bolvanský via Phabricator via cfe-commits
xbolva00 added a comment. In D97116#2596275 , @crownyanguan wrote: > However, this commit will cause performance regression. More details? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97116/new/ https://

[PATCH] D97116: Reduce the number of attributes attached to each function

2021-03-01 Thread crownyanguan via Phabricator via cfe-commits
crownyanguan added a comment. However, this commit will cause performance regression. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97116/new/ https://reviews.llvm.org/D97116 ___ cfe-commits mailing list

[PATCH] D97116: Reduce the number of attributes attached to each function

2021-02-23 Thread Dávid Bolvanský via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG053dc95839b3: Reduce the number of attributes attached to each function (authored by xbolva00). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo