[PATCH] D97119: [flang][driver] Add options for -std=f2018

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4c7ebf79e923: [flang][driver] Add options for -std=f2018 (authored by arnamoy10). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D97119: [flang][driver] Add options for -std=f2018

arnamoy10 updated this revision to Diff 11. arnamoy10 added a comment. Updating test case to add `-fsyntax-only` to share with `f18 ` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97119/new/ https://reviews.llvm.org/D97119 Files: clang/include/clang/Driver/Options.td clang/lib/

[PATCH] D97119: [flang][driver] Add options for -std=f2018

awarzynski accepted this revision. awarzynski added a comment. This revision is now accepted and ready to land. Thank you for updating this @arnamoy10! One thing worth pointing out - this patch adds `-pedantic` rather than `-fpendatic` as @richard.barton.arm suggested. That was clearly a typo, s

[PATCH] D97119: [flang][driver] Add options for -std=f2018

arnamoy10 updated this revision to Diff 332991. arnamoy10 added a comment. Rebasing on top of main CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97119/new/ https://reviews.llvm.org/D97119 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Flang.cpp flang/inc

[PATCH] D97119: [flang][driver] Add options for -std=f2018

arnamoy10 updated this revision to Diff 332703. arnamoy10 added a comment. 1. Leaning out the "wrong-option" test case 2. Adding aliases in f18 (`-pedantic` and `-std=2018` for `-Mstandard`) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97119/new/ https://reviews.llvm.org/D97119 Files:

[PATCH] D97119: [flang][driver] Add options for -std=f2018

awarzynski added inline comments. Comment at: flang/test/Driver/std2018.f90:1 +! REQUIRES: new-flang-driver +! Ensure argument -std=f2018 works as expected. arnamoy10 wrote: > awarzynski wrote: > > Would it be possible to share this test with `f18`? > Would you p

[PATCH] D97119: [flang][driver] Add options for -std=f2018

arnamoy10 added inline comments. Comment at: flang/test/Driver/std2018.f90:1 +! REQUIRES: new-flang-driver +! Ensure argument -std=f2018 works as expected. awarzynski wrote: > Would it be possible to share this test with `f18`? Would you please elaborate on how d

[PATCH] D97119: [flang][driver] Add options for -std=f2018

awarzynski added inline comments. Comment at: flang/test/Driver/std2018.f90:1 +! REQUIRES: new-flang-driver +! Ensure argument -std=f2018 works as expected. Would it be possible to share this test with `f18`? Comment at: flang/test/Driver/std20

[PATCH] D97119: [flang][driver] Add options for -std=f2018

arnamoy10 updated this revision to Diff 331871. arnamoy10 added a comment. Separating test cases for accepted input option and not accepted input option. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97119/new/ https://reviews.llvm.org/D97119 Files: clang/include/clang/Driver/Options

[PATCH] D97119: [flang][driver] Add options for -std=f2018

arnamoy10 updated this revision to Diff 330973. arnamoy10 added a comment. Moving -std to non-dialect option CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97119/new/ https://reviews.llvm.org/D97119 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Flang.cpp

[PATCH] D97119: [flang][driver] Add options for -std=f2018

arnamoy10 updated this revision to Diff 330823. arnamoy10 added a comment. Adding one more update that is probably required in semanticContext (inspired by f18), also updated test case to require flang-driver CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97119/new/ https://reviews.llvm

[PATCH] D97119: [flang][driver] Add options for -std=f2018

tskeith added inline comments. Comment at: flang/test/Driver/std2018.f90:9 +! RUN: %flang_fc1 -pedantic %s 2>&1 | FileCheck %s --check-prefix=GIVEN +! RUN: not %flang_fc1 -std=90 %s 2>&1 | FileCheck %s --check-prefix=WRONG + You need to make sure these work wit

[PATCH] D97119: [flang][driver] Add options for -std=f2018

arnamoy10 updated this revision to Diff 330762. arnamoy10 added a comment. 1. Update the test case to only test `flang-new -fc1` 2. Updated help text 3. Clang-formatted and also removed redundant code CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97119/new/ https://reviews.llvm.org/D971

[PATCH] D97119: [flang][driver] Add options for -std=f2018

awarzynski added inline comments. Comment at: clang/include/clang/Driver/Options.td:3535-3536 MarshallingInfoFlag>; -def pedantic : Flag<["-", "--"], "pedantic">, Group, Flags<[CC1Option]>, - MarshallingInfoFlag>; +def pedantic : Flag<["-", "--"], "pedantic">, Group, Flags<

[PATCH] D97119: [flang][driver] Add options for -std=f2018

arnamoy10 updated this revision to Diff 330023. arnamoy10 added a comment. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Updating the patch to make -pedantic and -f2018 behave the same way, also updated the test case accordingly. CHANGES SINCE LAST ACTION https://re

[PATCH] D97119: [flang][driver] Add options for -std=f2018

bryanpkc added a comment. I agree with @richard.barton.arm that we could add `-std=` now, even if only for a subset of possible language standards. I expect that standard conformance checks would be quite pervasive, and it would be better to design the infrastructure for such checks earlier rat

[PATCH] D97119: [flang][driver] Add options for -std=f2018

richard.barton.arm added a comment. I agree with @tskeith that `-Mstandard` is not exactly orthogonal to `-std`, the former being about warning for non-standard extensions/deviations and the latter being about use of standard fortran, but from a different standard version. I would expect `-Msta