tbaeder added a comment.
Thanks everyone!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97445/new/
https://reviews.llvm.org/D97445
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.ll
This revision was automatically updated to reflect the committed changes.
Closed by commit rG2cc58463caf4: [clang][sema] Ignore xor-used-as-pow if both
sides are macros (authored by tbaeder).
Changed prior to commit:
https://reviews.llvm.org/D97445?vs=326294&id=326386#toc
Repository:
rG LLVM
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM with a small nit, thanks!
Comment at: clang/lib/Sema/SemaExpr.cpp:12105
+ // Do not diagnose if both LHS and RHS are macros
+ if (XorLHS.get()->getExpr
xbolva00 added a comment.
No problem, +1
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97445/new/
https://reviews.llvm.org/D97445
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llv
tbaeder created this revision.
tbaeder added reviewers: xbolva00, aaron.ballman.
tbaeder requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
I've read both https://reviews.llvm.org/D63423 and
https://reviews.llvm.org/D66397, but I think both o