[PATCH] D97462: [clang][cli] Round-trip cc1 arguments in assert builds

arichardson added a comment. In D97462#2678889 , @jansvoboda11 wrote: > In D97462#2677130 , @arichardson > wrote: > >> I just merged this commit into our CHERI fork and noticed some failing tests >> due to round

[PATCH] D97462: [clang][cli] Round-trip cc1 arguments in assert builds

jansvoboda11 added a comment. In D97462#2677130 , @arichardson wrote: > I just merged this commit into our CHERI fork and noticed some failing tests > due to round tripping: > We add some additional CodeGenOptions and LangOptions, but are not including

[PATCH] D97462: [clang][cli] Round-trip cc1 arguments in assert builds

arichardson added a comment. I just merged this commit into our CHERI fork and noticed some failing tests due to round tripping: We add some additional CodeGenOptions and LangOptions, but are not including those in the generated command line. For example, I added an additional `std::string

[PATCH] D97462: [clang][cli] Round-trip cc1 arguments in assert builds

jansvoboda11 added a comment. In D97462#298 , @dexonsmith wrote: > In D97462#2666485 , @jansvoboda11 > wrote: > >> Thanks for reporting that. D99606 fixes >> one aspect of

[PATCH] D97462: [clang][cli] Round-trip cc1 arguments in assert builds

dexonsmith added a comment. In D97462#2666485 , @jansvoboda11 wrote: > Thanks for reporting that. D99606 fixes one > aspect of `-plugin-arg`, but it seems the order of generation is > non-deterministic (most likely

[PATCH] D97462: [clang][cli] Round-trip cc1 arguments in assert builds

jansvoboda11 added a comment. In D97462#2666366 , @akhuang wrote: > In Chrome we noticed that plugin flags are not being roundtripped (and build > fails with `error: Generated arguments do not match in round-trip`): > > example of the differing args: > >

[PATCH] D97462: [clang][cli] Round-trip cc1 arguments in assert builds

akhuang added a comment. In Chrome we noticed that plugin flags are not being roundtripped (and build fails with `error: Generated arguments do not match in round-trip`): example of the differing args: "-plugin-arg-blink-gc-plugin" "no-members-in-stack-allocated"

[PATCH] D97462: [clang][cli] Round-trip cc1 arguments in assert builds

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbb88a5aeee68: [clang][cli] Round-trip cc1 arguments in assert builds (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D97462: [clang][cli] Round-trip cc1 arguments in assert builds

jansvoboda11 added a comment. In D97462#2644406 , @arichardson wrote: > How expensive are these checks? If it is non-trivial overhead, maybe it > should default to `${LLVM_ENABLE_EXPENSIVE_CHECKS}` instead? Thanks for bringing that up. I measured the

[PATCH] D97462: [clang][cli] Round-trip cc1 arguments in assert builds

arichardson added a comment. How expensive are these checks? If it is non-trivial overhead, maybe it should default to `${LLVM_ENABLE_EXPENSIVE_CHECKS}` instead? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97462/new/

[PATCH] D97462: [clang][cli] Round-trip cc1 arguments in assert builds

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97462/new/ https://reviews.llvm.org/D97462

[PATCH] D97462: [clang][cli] Round-trip cc1 arguments in assert builds

jansvoboda11 updated this revision to Diff 328460. jansvoboda11 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97462/new/ https://reviews.llvm.org/D97462 Files: clang/CMakeLists.txt Index: clang/CMakeLists.txt

[PATCH] D97462: [clang][cli] Round-trip cc1 arguments in assert builds

jansvoboda11 updated this revision to Diff 326677. jansvoboda11 added a comment. Rebase on top of D97552 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97462/new/ https://reviews.llvm.org/D97462 Files:

[PATCH] D97462: [clang][cli] Round-trip cc1 arguments in assert builds

jansvoboda11 updated this revision to Diff 326398. jansvoboda11 added a comment. Rebase on top of D97461 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97462/new/ https://reviews.llvm.org/D97462 Files:

[PATCH] D97462: [clang][cli] Round-trip cc1 arguments in assert builds

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. Herald added a subscriber: mgorny. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch enables cc1 argument round-trip for assert