[PATCH] D97617: [clangd] ObjC fixes for semantic highlighting and xref highlights

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7d2fba8ddb90: [clangd] ObjC fixes for semantic highlighting and xref highlights (authored by sammccall). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D97617: [clangd] ObjC fixes for semantic highlighting and xref highlights

sammccall added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:657 +void VisitObjCInterfaceDecl(const ObjCInterfaceDecl *OID) { + if (OID->hasDefinition()) +visitProtocolList(OID->protocols(), OID->protocol_locs()); dgoldman

[PATCH] D97617: [clangd] ObjC fixes for semantic highlighting and xref highlights

sammccall updated this revision to Diff 327445. sammccall marked 6 inline comments as done. sammccall added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97617/new/ https://reviews.llvm.org/D97617 Files: clang-tools-e

[PATCH] D97617: [clangd] ObjC fixes for semantic highlighting and xref highlights

dgoldman added a comment. In D97617#2592424 , @sammccall wrote: > (not really sure why this suddenly seemed important to me, but if you don't > have semantic highlighting on, you're missing out!) Thanks! Comment at: clang-tools-extra/

[PATCH] D97617: [clangd] ObjC fixes for semantic highlighting and xref highlights

sammccall added a comment. (not really sure why this suddenly seemed important to me, but if you don't have semantic highlighting on, you're missing out!) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97617/new/ https://reviews.llvm.org/D97617 __

[PATCH] D97617: [clangd] ObjC fixes for semantic highlighting and xref highlights

sammccall created this revision. sammccall added a reviewer: dgoldman. Herald added subscribers: usaxena95, kadircet, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. - highlight references to proto