[PATCH] D97625: fix check-clang-tools tests that fail due to Windows CRLF line endings

thakis added a comment. > So I went ahead and just fixed this in > ac5f7be6a8688955a282becf00eebc542238a86b > . As far as we can tell, this broke clang-move/move-used-helper-decls.cpp on our windows bot. D124563

[PATCH] D97625: fix check-clang-tools tests that fail due to Windows CRLF line endings

aaronpuchert added a comment. In D97625#3337018 , @dmgreen wrote: > I'm not sure it will do much where it is. It won't, to quote **gitattributes**(5): > When deciding what attributes are assigned to a path, Git consults > `$GIT_DIR/info/attributes` file

[PATCH] D97625: fix check-clang-tools tests that fail due to Windows CRLF line endings

bcain added a comment. Herald added a project: All. In D97625#3337018 , @dmgreen wrote: > Hello. I noticed this was applied to the base /test directory in the llvm > repo: https://github.com/llvm/llvm-project/tree/main/test > Was it intended be in clang-t

[PATCH] D97625: fix check-clang-tools tests that fail due to Windows CRLF line endings

dmgreen added a comment. Hello. I noticed this was applied to the base /test directory in the llvm repo: https://github.com/llvm/llvm-project/tree/main/test Was it intended be in clang-tools-extra: https://github.com/llvm/llvm-project/tree/main/clang-tools-extra/test? I'm not sure it will do mu

[PATCH] D97625: fix check-clang-tools tests that fail due to Windows CRLF line endings

This revision was automatically updated to reflect the committed changes. Closed by commit rGfc5bf040d810: fix check-clang-tools tests that fail due to Windows CRLF line endings (authored by poelmanc, committed by LegalizeAdulthood). Herald added a project: LLVM. Herald added a subscriber: llvm-c

[PATCH] D97625: fix check-clang-tools tests that fail due to Windows CRLF line endings

poelmanc added a comment. Sorry I somehow missed the acceptance back on 10 Jan. I lack commit access, it would be great if you could push for me, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97625/new/ https://reviews.llvm.org/D97625 ___

[PATCH] D97625: fix check-clang-tools tests that fail due to Windows CRLF line endings

LegalizeAdulthood added a comment. Do you have commit access or do you need someone to push this change for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97625/new/ https://reviews.llvm.org/D97625 _

[PATCH] D97625: fix check-clang-tools tests that fail due to Windows CRLF line endings

LegalizeAdulthood added a comment. I have run into this line ending problem with python scripts as well. If you follow the advice on the "getting started" pages, then you will have checked out the entire repo with Unix line endings, but when you run python scripts like add_new_check.py for clang-t

[PATCH] D97625: fix check-clang-tools tests that fail due to Windows CRLF line endings

poelmanc created this revision. poelmanc added a reviewer: clang-tools-extra. poelmanc added a project: clang-tools-extra. Herald added a subscriber: jdoerfert. poelmanc requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Running `check-clang-t