[PATCH] D97653: [clang-tidy] Fix RenamerClangTidy checks breaking lambda captures.

aaron.ballman added a comment. In D97653#2681458 , @njames93 wrote: > Use implicit capture instead of default capture. > > @aaron.ballman, Unfortunately the AST dump tests don't work as implicit > captures don't appear to show up in the textual representa

[PATCH] D97653: [clang-tidy] Fix RenamerClangTidy checks breaking lambda captures.

njames93 updated this revision to Diff 336645. njames93 added a comment. Use implicit capture instead of default capture. @aaron.ballman, Unfortunately the AST dump tests don't work as implicit captures don't appear to show up in the textual representation. Repository: rG LLVM Github Monorep

[PATCH] D97653: [clang-tidy] Fix RenamerClangTidy checks breaking lambda captures.

njames93 added a comment. In D97653#2675005 , @aaron.ballman wrote: > In D97653#2593287 , @njames93 wrote: > >> Where would be a good place for testing refersToDefaultCapture support? > > Thank you for your patienc

[PATCH] D97653: [clang-tidy] Fix RenamerClangTidy checks breaking lambda captures.

aaron.ballman added a comment. In D97653#2593287 , @njames93 wrote: > Where would be a good place for testing refersToDefaultCapture support? Thank you for your patience while I thought about this a bit more, sorry for the delay in reviewing it! I think

[PATCH] D97653: [clang-tidy] Fix RenamerClangTidy checks breaking lambda captures.

njames93 added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97653/new/ https://reviews.llvm.org/D97653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D97653: [clang-tidy] Fix RenamerClangTidy checks breaking lambda captures.

njames93 added a comment. Herald added a project: clang-tools-extra. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97653/new/ https://reviews.llvm.org/D97653 ___ cfe-commits mailing list cfe-commit

[PATCH] D97653: [clang-tidy] Fix RenamerClangTidy checks breaking lambda captures.

njames93 updated this revision to Diff 327019. njames93 added a comment. Add a test case using init capture. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97653/new/ https://reviews.llvm.org/D97653 Files: clang-tools-extra/clang-tidy/utils/Renam

[PATCH] D97653: [clang-tidy] Fix RenamerClangTidy checks breaking lambda captures.

njames93 added a comment. Where would be a good place for testing refersToDefaultCapture support? Comment at: clang/lib/Sema/SemaLambda.cpp:1619 + if (Cap.isVariableCapture() && ImplicitCaptureLoc.isValid()) +cast(InitExpr)->setRefersToDefaultCapture(true); InitializedE

[PATCH] D97653: [clang-tidy] Fix RenamerClangTidy checks breaking lambda captures.

njames93 created this revision. njames93 added reviewers: alexfh, aaron.ballman, JonasToth, rsmith, MyDeveloperDay. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: shafik. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: c