[PATCH] D97753: [clang-tidy] Add a check for enforcing minimum length for variable names

aaron.ballman closed this revision. aaron.ballman added a comment. In D97753#2941277 , @0x8000- wrote: > The diff was generated with format-patch, so can be applied with "git am". > > The envelope: > >> commit d98d336b452876cfbc32ad1b76319912c45b646b (

[PATCH] D97753: [clang-tidy] Add a check for enforcing minimum length for variable names

0x8000- added a comment. The diff was generated with format-patch, so can be applied with "git am". The envelope: > commit d98d336b452876cfbc32ad1b76319912c45b646b (HEAD -> > readability-variable-name-length-main) > Author: Florin Iucha > Date: Mon Mar 1 00:57:01 2021 -0500 > > Add a c

[PATCH] D97753: [clang-tidy] Add a check for enforcing minimum length for variable names

aaron.ballman added a comment. In D97753#2940414 , @0x8000- wrote: > @aaron.ballman - thank you for the review; please submit on my behalf. Happy to do so, which name and email address would you like me to use for patch attribution? CHANGES SINCE L

[PATCH] D97753: [clang-tidy] Add a check for enforcing minimum length for variable names

0x8000- updated this revision to Diff 365891. 0x8000- added a comment. One more format nit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97753/new/ https://reviews.llvm.org/D97753 Files: clang-tools-extra/clang-tidy/readability/CMakeLists.txt clang-tools-extra/clang-tidy/r

[PATCH] D97753: [clang-tidy] Add a check for enforcing minimum length for variable names

0x8000- updated this revision to Diff 365879. 0x8000- added a comment. Reformatted the test file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97753/new/ https://reviews.llvm.org/D97753 Files: clang-tools-extra/clang-tidy/readability/CMakeLists.txt clang-tools-extra/clang-

[PATCH] D97753: [clang-tidy] Add a check for enforcing minimum length for variable names

0x8000- added a comment. @aaron.ballman - thank you for the review; please submit on my behalf. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97753/new/ https://reviews.llvm.org/D97753 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D97753: [clang-tidy] Add a check for enforcing minimum length for variable names

0x8000- updated this revision to Diff 365852. 0x8000- added a comment. Removed extra 'const' and parentheses that are not congruent with the accepted code style. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97753/new/ https://reviews.llvm.org/D97753 Files: clang-tools-extra

[PATCH] D97753: [clang-tidy] Add a check for enforcing minimum length for variable names

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some style nits (removing some top-level `const` we don't typically use, unnecessary paren expressions, and a typo fix), thank you for the check! =

[PATCH] D97753: [clang-tidy] Add a check for enforcing minimum length for variable names

0x8000- updated this revision to Diff 365651. 0x8000- added a comment. Clean diff against origin/main CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97753/new/ https://reviews.llvm.org/D97753 Files: clang-tools-extra/clang-tidy/readability/CMakeLists.txt clang-tools-extra/cl

[PATCH] D97753: [clang-tidy] Add a check for enforcing minimum length for variable names

0x8000- updated this revision to Diff 365622. 0x8000- added a comment. Rebased on main and renamed from readability-variable-length to readability-identifier-length. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97753/new/ https://reviews.llvm.org/D97753 Files: clang-tools-e

[PATCH] D97753: [clang-tidy] Add a check for enforcing minimum length for variable names

0x8000- added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ReadabilityTidyModule.cpp:136 +CheckFactories.registerCheck( +"readability-variable-length"); } aaron.ballman wrote: > 0x8000- wrote: > > aaron.ballman wro

[PATCH] D97753: [clang-tidy] Add a check for enforcing minimum length for variable names

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ReadabilityTidyModule.cpp:136 +CheckFactories.registerCheck( +"readability-variable-length"); } 0x8000- wrote: > aaron.ballman wrote: > > 0x8000- wro

[PATCH] D97753: [clang-tidy] Add a check for enforcing minimum length for variable names

0x8000- marked an inline comment as done. 0x8000- added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ReadabilityTidyModule.cpp:136 +CheckFactories.registerCheck( +"readability-variable-length"); } aaron.ballman wro

[PATCH] D97753: [clang-tidy] Add a check for enforcing minimum length for variable names

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ReadabilityTidyModule.cpp:136 +CheckFactories.registerCheck( +"readability-variable-length"); } 0x8000- wrote: > aaron.ballman wrote: > > Is there a reas

[PATCH] D97753: [clang-tidy] Add a check for enforcing minimum length for variable names

0x8000- updated this revision to Diff 365016. 0x8000- added a comment. Updated documentation for all options. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97753/new/ https://reviews.llvm.org/D97753 Files: clang-tools-extra/clang-tidy/readability/CMakeLists.txt clang-tools-

[PATCH] D97753: [clang-tidy] Add a check for enforcing minimum length for variable names

0x8000- updated this revision to Diff 364997. 0x8000- added a comment. Added separate check for parameter names. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97753/new/ https://reviews.llvm.org/D97753 Files: clang-tools-extra/clang-tidy/readability/CMakeLists.txt clang-too

[PATCH] D97753: [clang-tidy] Add a check for enforcing minimum length for variable names

0x8000- marked an inline comment as done. 0x8000- added a comment. Added regex for exception names and rebased onto current 'main' branch. Comment at: clang-tools-extra/clang-tidy/readability/ReadabilityTidyModule.cpp:136 +CheckFactories.registerCheck( +"re

[PATCH] D97753: [clang-tidy] Add a check for enforcing minimum length for variable names

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ReadabilityTidyModule.cpp:136 +CheckFactories.registerCheck( +"readability-variable-length"); } Is there a reason this should be restricted to variables? For

[PATCH] D97753: [clang-tidy] Add a check for enforcing minimum length for variable names

0x8000- added a comment. Ping? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97753/new/ https://reviews.llvm.org/D97753 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D97753: [clang-tidy] Add a check for enforcing minimum length for variable names

0x8000- updated this revision to Diff 327655. 0x8000- added a comment. Add an option "IgnoredVariableNames" that allows filtering out acceptable variable names (similar to the loop counters); also implemented via regex. Added tests for the IgnoredVariableNames option. CHANGES SINCE LAS

[PATCH] D97753: [clang-tidy] Add a check for enforcing minimum length for variable names

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability-variable-length.rst:21 + +Loop counter variables are expected to have a length of at least +`MinimumLoopCounterNameLength` characters (default is `2`).

[PATCH] D97753: [clang-tidy] Add a check for enforcing minimum length for variable names

0x8000- updated this revision to Diff 327653. 0x8000- marked an inline comment as done. 0x8000- added a comment. Use regular expression for filtering out loop counter variables to ignore. Fully document the options. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97753/new/ h

[PATCH] D97753: [clang-tidy] Add a check for enforcing minimum length for variable names

0x8000- marked an inline comment as done. 0x8000- added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability-variable-length.rst:9 + +Loop counter variables are expected to have a length of at least +`MinimumLoopCounterNameLength` characters

[PATCH] D97753: [clang-tidy] Add a check for enforcing minimum length for variable names

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability-variable-length.rst:9 + +Loop counter variables are expected to have a length of at least +`MinimumLoopCounterNameLength` characters (default is 2). Additionally, `i`,

[PATCH] D97753: [clang-tidy] Add a check for enforcing minimum length for variable names

0x8000- updated this revision to Diff 327649. 0x8000- added a comment. Addressed most of the review comments with the exception of switching to regex for ignoring loop counters; this change is in the follow-up review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97753/new/ htt

[PATCH] D97753: [clang-tidy] Add a check for enforcing minimum length for variable names

0x8000- marked 10 inline comments as done. 0x8000- added a comment. @Eugene.Zelenko and @njames93 Thank you both for the kind and thoughtful feedback. I am incorporating all recommended changes. First step are all the smaller scope comments, with regex support in a follow-up commit. I

[PATCH] D97753: [clang-tidy] Add a check for enforcing minimum length for variable names

njames93 added a comment. Please can you upload diffs with full context or using arcanist . It may be worth adding a case where if