This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
njames93 marked an inline comment as done.
Closed by commit rG00c7d6699a39: [cte][NFC] Remove all references to stdlib
stream headers. (authored by njames93).
Changed
njames93 added inline comments.
Comment at: clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp:38
+ if (!Buffer) {
+llvm::errs() << "Error cannot open JSON request file:" << FileName << ": "
+ << Buffer.getError().message() << "\n";
aaron
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
LGTM (apart from Aaron's comment!)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97771/new/
https://reviews.llvm.org/D97771
_
aaron.ballman added inline comments.
Comment at: clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp:38
+ if (!Buffer) {
+llvm::errs() << "Error cannot open JSON request file:" << FileName << ": "
+ << Buffer.getError().message() << "\n";
njames93 created this revision.
njames93 added reviewers: aaron.ballman, sammccall, alexfh.
Herald added subscribers: usaxena95, kadircet, arphaman.
njames93 requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Inclusion of iostream is frobidden
