[PATCH] D97960: [clang-tidy] bugprone-signal-handler improvements: display call chain

balazske abandoned this revision. balazske added a comment. Herald added subscribers: carlosgalvezp, steakhal. A new implementation is in D118224 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97960/new/ https://r

[PATCH] D97960: [clang-tidy] bugprone-signal-handler improvements: display call chain

martong added a comment. So, about the tests, gentle ping @njames93 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97960/new/ https://reviews.llvm.org/D97960 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D97960: [clang-tidy] bugprone-signal-handler improvements: display call chain

balazske added a subscriber: Eugene.Zelenko. balazske added a comment. In D97960#2611531 , @Eugene.Zelenko wrote: > I think call stack may be useful for other checks too. May be code should be > moved to utilities? Yes it is useful for other checks, but

[PATCH] D97960: [clang-tidy] bugprone-signal-handler improvements: display call chain

Eugene.Zelenko added a comment. I think call stack may be useful for other checks too. May be code should be moved to utilities? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97960/new/ https://reviews.llvm.org/D97960

[PATCH] D97960: [clang-tidy] bugprone-signal-handler improvements: display call chain

balazske updated this revision to Diff 329017. balazske added a comment. Adding test of notes. Tests are re-arranged significantly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97960/new/ https://reviews.llvm.org/D97960 Files: clang-tools-extra

[PATCH] D97960: [clang-tidy] bugprone-signal-handler improvements: display call chain

njames93 added a comment. The issue is FileCheck expects its directives to be in order they appear in the file being checked. Notes are always emitted just after the warning they are attached to. So there are a few ways to go: - use CHECK-NOTES-DAG to disregard the ordering and place them next

[PATCH] D97960: [clang-tidy] bugprone-signal-handler improvements: display call chain

balazske added a comment. I tried to test the notes but could not get it to work. I think the problem is related to the fact that the notes are displayed at different locations that are past or before the current warning. The solution could be to manually specify line numbers in the CHECK-NOTE

[PATCH] D97960: [clang-tidy] bugprone-signal-handler improvements: display call chain

njames93 added a comment. This needs tests demonstrating the notes. The defacto way is to replace all `CHECK-MESSAGES`Directives with `CHECK-NOTES`. This'll for file check to look for lines containing `note`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D97960: [clang-tidy] bugprone-signal-handler improvements: display call chain

balazske created this revision. Herald added subscribers: martong, gamesh411, Szelethus, dkrupp, xazax.hun, whisperity. balazske requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add a new feature to display the call chain if an unsafe funct