This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG4e1c487004a2: [clang] Fix crash when creating deduction
guide. (authored by adamcz).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTIO
adamcz added inline comments.
Comment at: clang/test/SemaCXX/cxx1z-class-template-argument-deduction.cpp:425
+ // This used to crash due to unparsed default arg above.
+ B(); // expected-error {{deduction guide declaration without trailing return
type}}
+};
ho
adamcz updated this revision to Diff 329346.
adamcz added a comment.
expanded a comment
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97965/new/
https://reviews.llvm.org/D97965
Files:
clang/lib/Sema/SemaTemplate.cpp
clang/test/SemaCXX/cxx1z-cl
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
Thanks!
Comment at: clang/test/SemaCXX/cxx1z-class-template-argument-deduction.cpp:425
+ // This used to crash due to unparsed default arg above.
+ B(); // expected-error {
adamcz updated this revision to Diff 328206.
adamcz added a comment.
format
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97965/new/
https://reviews.llvm.org/D97965
Files:
clang/lib/Sema/SemaTemplate.cpp
clang/test/SemaCXX/cxx1z-class-template
adamcz created this revision.
adamcz requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
We used to trigger assertion when transforming c-tor with unparsed
default argument. Now we ignore such constructors for this purpose.
Repository:
rG L
