mizvekov added inline comments.
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8968-8970
def note_defaulted_comparison_calls_deleted : Note<
"defaulted %0 is implicitly deleted because it would invoke a deleted "
"comparison function%select{| for member %2| f
This revision was automatically updated to reflect the committed changes.
Closed by commit rGc9fd92d57398: [clang] Improve diagnostics on implicitly
deleted defaulted comparisons (authored by mizvekov).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D9
mizvekov added inline comments.
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8968-8970
def note_defaulted_comparison_calls_deleted : Note<
"defaulted %0 is implicitly deleted because it would invoke a deleted "
"comparison function%select{| for member %2| f
rsmith accepted this revision.
rsmith added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8968-8970
def note_defaulted_comparison_calls_deleted : Note<
"defaulted %0 is implicitly deleted because
mizvekov updated this revision to Diff 329289.
mizvekov added a comment.
Change to simpler way to do it:
For CompleteObject Kind, just fill in the declaration for the complete object.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97990/new/
https:/
mizvekov added a comment.
You are absolutely right, my bad!!
So we stealth fix this revision to improve the message :D
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97990/new/
https://reviews.llvm.org/D97990
__
