This revision was automatically updated to reflect the committed changes.
fhahn marked an inline comment as done.
Closed by commit rGfc8d3766d721: [ExtVectorType] Support conditional select
operator for C++. (authored by fhahn).
Changed prior to commit:
fhahn marked an inline comment as done.
fhahn added inline comments.
Comment at: clang/lib/Sema/SemaExprCXX.cpp:6172-6174
+ if (IsVectorConditional) {
+return CheckVectorConditionalTypes(Cond, LHS, RHS, QuestionLoc);
+ }
aaron.ballman wrote:
>
I'll fix
aaron.ballman accepted this revision.
aaron.ballman added a comment.
LGTM!
Comment at: clang/lib/Sema/SemaExprCXX.cpp:6172-6174
+ if (IsVectorConditional) {
+return CheckVectorConditionalTypes(Cond, LHS, RHS, QuestionLoc);
+ }
Repository:
rG LLVM
fhahn added inline comments.
Comment at: clang/lib/Sema/SemaExprCXX.cpp:5951
const QualType EltTy =
- cast(CondTy.getCanonicalType())->getElementType();
+ CondTy->isVectorType()
+ ? cast(CondTy.getCanonicalType())->getElementType()
fhahn updated this revision to Diff 328815.
fhahn added a comment.
Got rid of the template parameter, greatly simplified the code.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98055/new/
https://reviews.llvm.org/D98055
Files:
erichkeane added inline comments.
Comment at: clang/lib/Sema/SemaExprCXX.cpp:5951
const QualType EltTy =
- cast(CondTy.getCanonicalType())->getElementType();
+ CondTy->isVectorType()
+ ? cast(CondTy.getCanonicalType())->getElementType()
Why
fhahn created this revision.
fhahn added reviewers: rjmccall, erichkeane, aaron.ballman.
fhahn requested review of this revision.
Herald added a project: clang.
This patch implements the conditional select operator for
ext_vector_types in C++. It does so by using the same semantics as for
C.
