[PATCH] D98134: [WIP][RFC] Introduce callback argument encoding mode into callback metadata

2021-03-08 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 updated this revision to Diff 329191. tianshilei1992 added a comment. update llvm doc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98134/new/ https://reviews.llvm.org/D98134 Files: clang/include/clang/Basic/AttrDocs.td clang/in

[PATCH] D98134: [WIP][RFC] Introduce callback argument encoding mode into callback metadata

2021-03-08 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 updated this revision to Diff 329163. tianshilei1992 added a comment. update doc in clang Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98134/new/ https://reviews.llvm.org/D98134 Files: clang/include/clang/Basic/AttrDocs.td clan

[PATCH] D98134: [WIP][RFC] Introduce callback argument encoding mode into callback metadata

2021-03-06 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:3679 S.Diag(AL.getLoc(), diag::err_attribute_wrong_number_arguments) -<< AL << (unsigned)(EncodingIndices.size() - 1); +<< AL << (unsigned)(CalleeFnProtoType->getNumParams() + 2

[PATCH] D98134: [WIP][RFC] Introduce callback argument encoding mode into callback metadata

2021-03-06 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 created this revision. Herald added subscribers: dexonsmith, okura, kuter, hiraditya. Herald added a reviewer: aaron.ballman. tianshilei1992 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a reviewer: jdoerfert. Herald added a reviewer: sstefan1. H