This revision was automatically updated to reflect the committed changes.
Closed by commit rG33b1f3f42cb9: [clang][patch] Solve PR49479, File scope fp
pragma should propagate to… (authored by mibintc).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98
aaron.ballman accepted this revision.
aaron.ballman added a comment.
LGTM as well, but feel free to give the other reviewers a chance to weigh in.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98211/new/
https://reviews.llvm.org/D98211
___
erichkeane accepted this revision.
erichkeane added a comment.
This revision is now accepted and ready to land.
The description of the problem, and hte patch and tests seem to make sense, so
I think this should be ok. Please give some of the others a little bit of
time before committing to spe
mibintc added inline comments.
Comment at: clang/lib/Parse/ParseDeclCXX.cpp:3419
// delayed attributes.
SourceLocation SavedPrevTokLocation = PrevTokLocation;
I remember worrying about this issue when I wrote the initial patch but I can't
remember wh
mibintc created this revision.
mibintc added reviewers: kpn, erichkeane, rjmccall.
mibintc requested review of this revision.
Herald added a project: clang.
Currently, the CurFPFeatures state is set to command line settings before
semantic analysis of the nested member functions and initializatio