[PATCH] D98214: [clang-format] Fix aligning with linebreaks

HazardyKnusperkeks added a comment. In D98214#2901304 , @baramin wrote: > This is true. > .clang-format: > > Language:Cpp > AlignConsecutiveAssignments: Consecutive > BinPackArguments: false > BinPackParameters: false > ColumnLimit:

[PATCH] D98214: [clang-format] Fix aligning with linebreaks

HazardyKnusperkeks added a comment. In D98214#2901304 , @baramin wrote: > This is true. > .clang-format: > > Language:Cpp > AlignConsecutiveAssignments: Consecutive > BinPackArguments: false > BinPackParameters: false > ColumnLimit:

[PATCH] D98214: [clang-format] Fix aligning with linebreaks

baramin added a comment. This is true. .clang-format: Language:Cpp AlignConsecutiveAssignments: Consecutive BinPackArguments: false BinPackParameters: false ColumnLimit: 120 ConstructorInitializerIndentWidth: 4 ContinuationIndentWidth: 4 IndentWidth: 4 TabWidth:

[PATCH] D98214: [clang-format] Fix aligning with linebreaks

HazardyKnusperkeks added a comment. In D98214#2900803 , @baramin wrote: > You are right. > > The problem is in > > FromLegacyTimestamp(monitorFrequencyUsec), > seconds(std::uint64_t(maxSampleAge)), maxKeepSamples)); > > line indentation. It is 6 instead

[PATCH] D98214: [clang-format] Fix aligning with linebreaks

baramin added a comment. You are right. The problem is in FromLegacyTimestamp(monitorFrequencyUsec), seconds(std::uint64_t(maxSampleAge)), maxKeepSamples)); line indentation. It is 6 instead of 4. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D98214: [clang-format] Fix aligning with linebreaks

MyDeveloperDay added a comment. In D98214#2900371 , @baramin wrote: > We have a regression after the fix: > CPP-25899 CLion formatting > does not match what clang-format produces > > if > > AlignConsecuti

[PATCH] D98214: [clang-format] Fix aligning with linebreaks

baramin added a comment. We have a regression after the fix: CPP-25899 CLion formatting does not match what clang-format produces if AlignConsecutiveAssignments: Consecutive Additional two spaces before `=` were added to indentation while form

[PATCH] D98214: [clang-format] Fix aligning with linebreaks

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc5243c63cda3: [clang-format] Fix aligning with linebreaks (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D98214: [clang-format] Fix aligning with linebreaks

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. Let some time to others to have a look before landing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98214/new/ https://reviews.llvm.o

[PATCH] D98214: [clang-format] Fix aligning with linebreaks

HazardyKnusperkeks updated this revision to Diff 329755. HazardyKnusperkeks marked 2 inline comments as done. HazardyKnusperkeks added a comment. - Addressed comments - Fixed handling of continued string literals when aligning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D98214: [clang-format] Fix aligning with linebreaks

curdeius added inline comments. Comment at: clang/lib/Format/WhitespaceManager.cpp:332-340 if (Changes[ScopeStart - 1].Tok->is(TT_FunctionDeclarationName) || (ScopeStart > Start + 1 && Changes[ScopeStart - 2].Tok->is(TT_FunctionDeclarationName)) || +

[PATCH] D98214: [clang-format] Fix aligning with linebreaks

HazardyKnusperkeks marked 2 inline comments as done. HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/WhitespaceManager.cpp:332-340 if (Changes[ScopeStart - 1].Tok->is(TT_FunctionDeclarationName) || (ScopeStart > Start + 1 && Ch

[PATCH] D98214: [clang-format] Fix aligning with linebreaks

curdeius requested changes to this revision. curdeius added a comment. This revision now requires changes to proceed. This looks really good. Just a few rather minor remarks. Comment at: clang/lib/Format/WhitespaceManager.cpp:280-281 // In the above example, we need to take

[PATCH] D98214: [clang-format] Fix aligning with linebreaks

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, curdeius, nikola. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Breaking a