[PATCH] D98246: [clangd] Add basic monitoring info request for remote index server

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG524fe515091d: [clangd] Add basic monitoring info request for remote index server (authored by kbobyrev). Repository: rG LLVM Github Monorepo

[PATCH] D98246: [clangd] Add basic monitoring info request for remote index server

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! let's ship it! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98246/new/ https://reviews.llvm.org/D98246

[PATCH] D98246: [clangd] Add basic monitoring info request for remote index server

kbobyrev updated this revision to Diff 330937. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Resolve review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98246/new/ https://reviews.llvm.org/D98246 Files:

[PATCH] D98246: [clangd] Add basic monitoring info request for remote index server

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:308 + .count()); +// FIXME(kirillbobyrev): This is not really "freshness", this is just the +// time since last index reload.

[PATCH] D98246: [clangd] Add basic monitoring info request for remote index server

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:308 + .count()); +// FIXME(kirillbobyrev): This is not really "freshness", this is just the +// time since last index reload.

[PATCH] D98246: [clangd] Add basic monitoring info request for remote index server

kbobyrev updated this revision to Diff 330791. kbobyrev marked 7 inline comments as done. kbobyrev added a comment. Herald added a subscriber: jfb. Address comments, rebase on top of main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98246/new/

[PATCH] D98246: [clangd] Add basic monitoring info request for remote index server

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/remote/MonitoringService.proto:17 + optional uint64 uptime = 1; + // Time since the index was built on the indexing machine. + optional uint64 freshness = 3; mention the units in here

[PATCH] D98246: [clangd] Add basic monitoring info request for remote index server

kbobyrev updated this revision to Diff 330681. kbobyrev marked 6 inline comments as done. kbobyrev added a comment. Herald added a project: clang-tools-extra. Resolve review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98246/new/

[PATCH] D98246: [clangd] Add basic monitoring info request for remote index server

kadircet added a comment. thanks! this mostly LG, just a couple comments here and there. > The current format is "store seconds since X event". I think this is great for certain things like freshness, so thanks! > Should we store UNIX timestamps instead? This is probably not portable until >

[PATCH] D98246: [clangd] Add basic monitoring info request for remote index server

kbobyrev updated this revision to Diff 329865. kbobyrev marked 8 inline comments as done. kbobyrev added a comment. Address review comments. The current format is "store seconds since X event". Should we store UNIX timestamps instead? This is probably not portable until C++20, so maybe it isn't

[PATCH] D98246: [clangd] Add basic monitoring info request for remote index server

sammccall added inline comments. Comment at: clang-tools-extra/clangd/index/remote/Service.proto:16 +message MonitoringInfoReply { optional string info = 1; } + sammccall wrote: > kadircet wrote: > > i am not sure if having more structure here immediately vs.

[PATCH] D98246: [clangd] Add basic monitoring info request for remote index server

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/remote/Service.proto:13 +import "google/protobuf/empty.proto"; import "Index.proto"; sammccall wrote: > question of style, but unless there's a concrete benefit I'd suggest just >

[PATCH] D98246: [clangd] Add basic monitoring info request for remote index server

kbobyrev updated this revision to Diff 329553. kbobyrev marked an inline comment as done. kbobyrev added a comment. Enabled server reflection in https://github.com/llvm/llvm-project/commit/8080ea4c4b8c456c72c617587cc32f174b3105c1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D98246: [clangd] Add basic monitoring info request for remote index server

sammccall added inline comments. Comment at: clang-tools-extra/clangd/index/remote/Service.proto:13 +import "google/protobuf/empty.proto"; import "Index.proto"; question of style, but unless there's a concrete benefit I'd suggest just defining the request

[PATCH] D98246: [clangd] Add basic monitoring info request for remote index server

kbobyrev updated this revision to Diff 329312. kbobyrev added a comment. Herald added subscribers: llvm-commits, mgorny. Herald added a project: LLVM. Use reflection, improve message format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98246/new/

[PATCH] D98246: [clangd] Add basic monitoring info request for remote index server

kbobyrev created this revision. kbobyrev added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo