[PATCH] D98358: [OpenMP] Restore backwards compatibility for libomptarget

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG807466ef2812: [OpenMP] Restore backwards compatibility for libomptarget (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D98358: [OpenMP] Restore backwards compatibility for libomptarget

cchen accepted this revision. cchen added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98358/new/ https://reviews.llvm.org/D98358 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D98358: [OpenMP] Restore backwards compatibility for libomptarget

jhuber6 updated this revision to Diff 329709. jhuber6 added a comment. Updating tests and adding the new function to the exports. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98358/new/ https://reviews.llvm.org/D98358 Files: clang/lib/CodeGen/C

[PATCH] D98358: [OpenMP] Restore backwards compatibility for libomptarget

jhuber6 added a comment. In D98358#2617152 , @cchen wrote: > I think some existing Clang OpenMP codegen tests will break if they are > testing against `__kmpc_push_target_tripcount`. I'm working on fixing the tests, I also forgot to include it in the `ex

[PATCH] D98358: [OpenMP] Restore backwards compatibility for libomptarget

cchen added a comment. I think some existing Clang OpenMP codegen tests will break if they are testing against `__kmpc_push_target_tripcount`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98358/new/ https://reviews.llvm.org/D98358 __

[PATCH] D98358: [OpenMP] Restore backwards compatibility for libomptarget

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG. We should have a test that references the entire interface so we realize if something breaks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D98358: [OpenMP] Restore backwards compatibility for libomptarget

jhuber6 created this revision. jhuber6 added a reviewer: jdoerfert. Herald added subscribers: guansong, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: llvm-commits, openmp-commits, cfe-commits, sstefan1. Herald added projects: clang, OpenMP, LLVM. The changes introduc