[PATCH] D98493: [WoA][MSVC] Use default linker setting in MSVC-compatible driver

phosek added a comment. In D98493#2636648 , @maxim-kuvyrkov wrote: > In D98493#2636616 , @phosek wrote: > >> They're not part of buildbot but they're not internal, you can see the log >> here: >>

[PATCH] D98493: [WoA][MSVC] Use default linker setting in MSVC-compatible driver

maxim-kuvyrkov added a comment. In D98493#2636616 , @phosek wrote: > They're not part of buildbot but they're not internal, you can see the log > here: >

[PATCH] D98493: [WoA][MSVC] Use default linker setting in MSVC-compatible driver

phosek added a comment. They're not part of buildbot but they're not internal, you can see the log here: https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket.appspot.com/8852352747956966400/+/u/clang/test/stdout. I noticed D98862 , but it still

[PATCH] D98493: [WoA][MSVC] Use default linker setting in MSVC-compatible driver

maxim-kuvyrkov added a comment. Hi @phosek , The only upstream bot that was broken by this change was clang-ppc64le-rhel, and I have notified the bot owner of the problem and said that I'm working on this within 15 minutes of the breakage. I posted a tentative fix for the testsuite several

[PATCH] D98493: [WoA][MSVC] Use default linker setting in MSVC-compatible driver

phosek added a comment. This is still broken, we're seeing multiple failing tests, can we please revert this change for now? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98493/new/ https://reviews.llvm.org/D98493

[PATCH] D98493: [WoA][MSVC] Use default linker setting in MSVC-compatible driver

maxim-kuvyrkov added a comment. In D98493#2634107 , @SureYeaah wrote: > We are seeing some internal breakage in google because CLANG_DEFAULT_LINKER > is set to ld. It would be nice to make the tests more tolerant. > > Can we revert this patch until then?

[PATCH] D98493: [WoA][MSVC] Use default linker setting in MSVC-compatible driver

SureYeaah added a comment. We are seeing some internal breakage in google because CLANG_DEFAULT_LINKER is set to ld. It would be nice to make the tests more tolerant. Can we revert this patch until then? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D98493: [WoA][MSVC] Use default linker setting in MSVC-compatible driver

maxim-kuvyrkov added a comment. In D98493#2634089 , @SureYeaah wrote: > What if CLANG_DEFAULT_LINKER=ld? @SureYeaah , then *-msvc targets will attempt to use "ld" linker as instructed. Or are you asking about something else? Repository: rG LLVM

[PATCH] D98493: [WoA][MSVC] Use default linker setting in MSVC-compatible driver

maxim-kuvyrkov added a comment. This patch broke clang-ppc64le-rhel builder. The patch makes MSVC-compatible driver honour CLANG_DEFAULT_LINKER setting, which this builder sets to “lld”. Therefore there’s an expected change in the output now that CLANG_DEFAULT_LINKER can override link.exe.

[PATCH] D98493: [WoA][MSVC] Use default linker setting in MSVC-compatible driver

SureYeaah added a comment. What if CLANG_DEFAULT_LINKER=ld? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98493/new/ https://reviews.llvm.org/D98493 ___ cfe-commits mailing list

[PATCH] D98493: [WoA][MSVC] Use default linker setting in MSVC-compatible driver

maxim-kuvyrkov added a subscriber: tstellar. maxim-kuvyrkov added a comment. @tstellar , OK to backport to release/12.x if buildbots are happy with this? I've filed https://bugs.llvm.org/show_bug.cgi?id=49624 with background info. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D98493: [WoA][MSVC] Use default linker setting in MSVC-compatible driver

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGace56d41aca8: [WoA][MSVC] Use default linker setting in MSVC-compatible driver (authored by maxim-kuvyrkov). Repository: rG LLVM Github Monorepo

[PATCH] D98493: [WoA][MSVC] Use default linker setting in MSVC-compatible driver

asl accepted this revision. asl added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98493/new/ https://reviews.llvm.org/D98493

[PATCH] D98493: [WoA][MSVC] Use default linker setting in MSVC-compatible driver

maxim-kuvyrkov added inline comments. Comment at: clang/lib/Driver/ToolChains/MSVC.cpp:582 + StringRef Linker = Args.getLastArgValue(options::OPT_fuse_ld_EQ, + CLANG_DEFAULT_LINKER); + if (Linker.empty()) asl wrote: >

[PATCH] D98493: [WoA][MSVC] Use default linker setting in MSVC-compatible driver

asl added inline comments. Comment at: clang/lib/Driver/ToolChains/MSVC.cpp:582 + StringRef Linker = Args.getLastArgValue(options::OPT_fuse_ld_EQ, + CLANG_DEFAULT_LINKER); + if (Linker.empty()) How is

[PATCH] D98493: [WoA][MSVC] Use default linker setting in MSVC-compatible driver

maxim-kuvyrkov updated this revision to Diff 330272. maxim-kuvyrkov added a comment. Added missing header to pull in definition of CLANG_DEFAULT_LINKER. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98493/new/ https://reviews.llvm.org/D98493

[PATCH] D98493: [WoA][MSVC] Use default linker setting in MSVC-compatible driver

maxim-kuvyrkov created this revision. maxim-kuvyrkov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. At the moment "link.exe" is hard-coded as default linker in MSVC.cpp, so there's no way to use LLD as default linker for MSVC driver.