This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGbb6d96ced80f: [clangd] Enable modules to contribute tweaks.
(authored by kadircet).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
kadircet updated this revision to Diff 332552.
kadircet marked 4 inline comments as done.
kadircet added a comment.
Herald added a subscriber: mgorny.
- Add test
- Move forward declarations out of signatures
- Move FeatureModuleSets to the last parameter in prepareTweaks
Repository:
rG LLVM
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Herald added a project: clang-tools-extra.
Should we have a test somewhere that tweaks defined in modules actually work?
Comment at:
kadircet created this revision.
kadircet added a reviewer: sammccall.
Herald added subscribers: usaxena95, arphaman.
kadircet requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang.
First patch to enable diagnostic fix
