[PATCH] D98712: [Utils] Support lit-like substitutions in update_cc_test_checks

2021-03-23 Thread Giorgis Georgakoudis via Phabricator via cfe-commits
ggeorgakoudis added inline comments. Comment at: llvm/utils/update_cc_test_checks.py:228 + '%t' : tempfile.NamedTemporaryFile().name, + '%S' : os.getcwd(), +} arichardson wrote: > Shouldn't this be the directory containing the test? You are right,

[PATCH] D98712: [Utils] Support lit-like substitutions in update_cc_test_checks

2021-03-16 Thread Alexander Richardson via Phabricator via cfe-commits
arichardson added inline comments. Comment at: llvm/utils/update_cc_test_checks.py:228 + '%t' : tempfile.NamedTemporaryFile().name, + '%S' : os.getcwd(), +} Shouldn't this be the directory containing the test? Repository: rG LLVM Github Monorep

[PATCH] D98712: [Utils] Support lit-like substitutions in update_cc_test_checks

2021-03-16 Thread Giorgis Georgakoudis via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa80a33e8b553: [Utils] Support lit-like substitutions in update_cc_test_checks (authored by ggeorgakoudis). Repository: rG LLVM Github Monorepo CH

[PATCH] D98712: [Utils] Support lit-like substitutions in update_cc_test_checks

2021-03-16 Thread Giorgis Georgakoudis via Phabricator via cfe-commits
ggeorgakoudis updated this revision to Diff 331037. ggeorgakoudis added a comment. Update test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98712/new/ https://reviews.llvm.org/D98712 Files: clang/test/utils/update_cc_test_checks/Inputs/exec-all

[PATCH] D98712: [Utils] Support lit-like substitutions in update_cc_test_checks

2021-03-16 Thread Giorgis Georgakoudis via Phabricator via cfe-commits
ggeorgakoudis updated this revision to Diff 331035. ggeorgakoudis added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98712/new/ https://reviews.llvm.org/D98