[PATCH] D98862: [clang] Update unit-tests after linker selection fix for *-msvc targets

2021-03-19 Thread Maxim Kuvyrkov via Phabricator via cfe-commits
maxim-kuvyrkov abandoned this revision. maxim-kuvyrkov added a comment. This is now squashed into https://reviews.llvm.org/D98935 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98862/new/ https://reviews.llvm.org/D98862

[PATCH] D98862: [clang] Update unit-tests after linker selection fix for *-msvc targets

2021-03-19 Thread Petr Hosek via Phabricator via cfe-commits
phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. I've tested this locally and it's working for us. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98862/new/ https://reviews.llvm.org/D98862

[PATCH] D98862: [clang] Update unit-tests after linker selection fix for *-msvc targets

2021-03-19 Thread Maxim Kuvyrkov via Phabricator via cfe-commits
maxim-kuvyrkov added a comment. Hi @amyk , thanks for testing -- I've updated two more places, which I missed on the first go. Would you please test the new version? Also, D98862 was reverted so you need to apply it manually. Thanks! Repository: rG LLVM G

[PATCH] D98862: [clang] Update unit-tests after linker selection fix for *-msvc targets

2021-03-19 Thread Maxim Kuvyrkov via Phabricator via cfe-commits
maxim-kuvyrkov updated this revision to Diff 331784. maxim-kuvyrkov added a comment. Added more fixes to OpenMP/linking.c and Driver/msvc-link.c . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98862/new/ https://reviews.llvm.org/D98862 Files: cl

[PATCH] D98862: [clang] Update unit-tests after linker selection fix for *-msvc targets

2021-03-18 Thread Amy Kwan via Phabricator via cfe-commits
amyk added a comment. Hi, Thanks for fixing the tests. I've tested this patch on the environment of `clang-ppc64le-rhel` (https://lab.llvm.org/buildbot/#/builders/57), and there seems to be two failures that still remain: Failed Tests (2): Clang :: OpenMP/linking.c Clang :: Driver/ms

[PATCH] D98862: [clang] Update unit-tests after linker selection fix for *-msvc targets

2021-03-18 Thread Maxim Kuvyrkov via Phabricator via cfe-commits
maxim-kuvyrkov added a comment. @SureYeaah , does this fix your internal buildbot? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98862/new/ https://reviews.llvm.org/D98862 ___ cfe-commits mailing list cf

[PATCH] D98862: [clang] Update unit-tests after linker selection fix for *-msvc targets

2021-03-18 Thread Maxim Kuvyrkov via Phabricator via cfe-commits
maxim-kuvyrkov created this revision. maxim-kuvyrkov added a reviewer: asl. maxim-kuvyrkov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. After https://reviews.llvm.org/D98493 clang driver for *-msvc target uses linker from CLANG_DEFAULT_L