vsapsai accepted this revision.
vsapsai added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/lib/AST/ExprConstant.cpp:972-973
+// Determine if we might warn that the given expression exhibits undefined
+// behavior.
+bool mightWa
rsmith added inline comments.
Comment at: clang/lib/AST/ExprConstant.cpp:972-973
+// Determine if we might warn that the given expression exhibits undefined
+// behavior.
+bool mightWarnOnUndefinedBehavior(const Expr *E) {
vsapsai wrote:
> I'm not e
vsapsai added a comment.
Looks good to me. Have a few clarification questions.
Comment at: clang/lib/AST/ExprConstant.cpp:972-973
+// Determine if we might warn that the given expression exhibits undefined
+// behavior.
+bool mightWarnOnUndefinedBehavior(const Exp
rsmith created this revision.
rsmith added a reviewer: vsapsai.
rsmith requested review of this revision.
Herald added a project: clang.
Previously -Winteger-overflow did not do any checking of expressions
whose top-level syntactic form wasn't one of a small list of special
cases. This meant that
