yaxunl marked 2 inline comments as done.
yaxunl added inline comments.
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:7215
+// warnings as errors.
+CmdArgs.push_back("-Werror=atomic-alignment");
}
tra wrote:
> Should it be done from `HIPAMDToolChain
MaskRay added inline comments.
Comment at: clang/test/Driver/hip-options.hip:144
+
+// RUN: %clang -### -target x86_64-unknown-linux-gnu -nogpuinc -nogpulib \
+// RUN: --cuda-gpu-arch=gfx906 %s 2>&1 | FileCheck -check-prefix=WARN-ATOMIC
%s
Prefer `--target=` t
tra added inline comments.
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:7215
+// warnings as errors.
+CmdArgs.push_back("-Werror=atomic-alignment");
}
Should it be done from `HIPAMDToolChain::addClangWarningOptions` ?
That's where Darwin does sim
yaxunl added a comment.
ping
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99201/new/
https://reviews.llvm.org/D99201
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaxunl updated this revision to Diff 528937.
yaxunl added a comment.
Herald added a subscriber: MaskRay.
Herald added a project: All.
rebase and simplify code
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99201/new/
https://reviews.llvm.org/D99201
Files:
clang/lib/Driver/ToolChains/C
yaxunl created this revision.
yaxunl added reviewers: tra, rjmccall, jfb.
Herald added subscribers: kerbowa, t-tye, tpr, dstuttard, nhaehnle, jvesely,
kzhuravl.
yaxunl requested review of this revision.
Herald added a subscriber: wdng.
https://reviews.llvm.org/D99201
Files:
clang/lib/Driver/To