[PATCH] D99231: [AST] Add introspection support for more base nodes

This revision was automatically updated to reflect the committed changes. Closed by commit rGf347f0e0b869: [AST] Add introspection support for more base nodes (authored by stephenkelly). Changed prior to commit: https://reviews.llvm.org/D99231?vs=336813&id=337537#toc Repository: rG LLVM Gith

[PATCH] D99231: [AST] Add introspection support for more base nodes

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:2270 SourceLocation getEllipsisLoc() const { -assert(isPackExpansion() && "Initializer is not a pack expansion"); +if (!isPackExpansion()) + return {}; steveire wro

[PATCH] D99231: [AST] Add introspection support for more base nodes

steveire added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:2270 SourceLocation getEllipsisLoc() const { -assert(isPackExpansion() && "Initializer is not a pack expansion"); +if (!isPackExpansion()) + return {}; njames93 wrote: >

[PATCH] D99231: [AST] Add introspection support for more base nodes

njames93 added subscribers: aaron.ballman, rsmith. njames93 added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:2270 SourceLocation getEllipsisLoc() const { -assert(isPackExpansion() && "Initializer is not a pack expansion"); +if (!isPackExpansion()) +

[PATCH] D99231: [AST] Add introspection support for more base nodes

steveire updated this revision to Diff 336813. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99231/new/ https://reviews.llvm.org/D99231 Files: clang/include/clang/AST/DeclCXX.h clang/include/clang/Tooling/NodeI

[PATCH] D99231: [AST] Add introspection support for more base nodes

steveire added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:2270 SourceLocation getEllipsisLoc() const { -assert(isPackExpansion() && "Initializer is not a pack expansion"); +if (!isPackExpansion()) + return {}; njames93 wrote: >

[PATCH] D99231: [AST] Add introspection support for more base nodes

steveire updated this revision to Diff 336804. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99231/new/ https://reviews.llvm.org/D99231 Files: clang/include/clang/AST/DeclCXX.h clang/include/clang/Tooling/NodeI

[PATCH] D99231: [AST] Add introspection support for more base nodes

njames93 added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:2270 SourceLocation getEllipsisLoc() const { -assert(isPackExpansion() && "Initializer is not a pack expansion"); +if (!isPackExpansion()) + return {}; I'm not sure abou

[PATCH] D99231: [AST] Add introspection support for more base nodes

steveire updated this revision to Diff 336651. steveire added a comment. Add locations for CXXBaseSpecifier Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99231/new/ https://reviews.llvm.org/D99231 Files: clang/include/clang/AST/DeclCXX.h clang

[PATCH] D99231: [AST] Add introspection support for more base nodes

steveire added a comment. @njames93 ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99231/new/ https://reviews.llvm.org/D99231 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D99231: [AST] Add introspection support for more base nodes

steveire created this revision. steveire added a reviewer: njames93. Herald added a subscriber: mgorny. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Replace an assert for a CXXCtorInitializer SourceLocation with a condition, as