This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG6951b72334bb: [clang] Speedup line offset mapping
computation (authored by serge-sans-paille).
Herald added a project: clang.
Herald added a subscrib
RKSimon added a comment.
@serge-sans-paille Please can you look at the clang-ppc buildbot breakages:
http://lab.llvm.org:8011/#/builders/52/builds/6108
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99409/new/
https://reviews.llvm.org/D99409
_
thakis added a comment.
Looks like this breaks tests on Windows:
http://45.33.8.238/win/36495/step_7.txt (takes a bit to load, since many tests
are broken)
Please take a look, and please revert for now if it takes a while to fix.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTIO
thakis added a comment.
Here too: http://lab.llvm.org:8011/#/builders/127
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99409/new/
https://reviews.llvm.org/D99409
___
cfe-commits mailing list
cfe-commits
thakis added a comment.
Oh, looks like someone already reported a breakage over an hour ago. I'll
revert for now...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99409/new/
https://reviews.llvm.org/D99409
_
serge-sans-paille added a comment.
Thanks @thakis, inestigating the issue is likely to take some time as it seems
to be arch or system dependent
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99409/new/
https://reviews.llvm.org/D99409
thakis added inline comments.
Comment at: clang/lib/Basic/SourceManager.cpp:1262
+ unsigned char n) {
+ return ((x - ~0UL / 255 * (n + 1)) & ~x &
+ (x & ~0UL / 255 * 127) + ~0UL / 255 * (127 - (m - 1))) &
UL is
serge-sans-paille added inline comments.
Comment at: clang/lib/Basic/SourceManager.cpp:1262
+ unsigned char n) {
+ return ((x - ~0UL / 255 * (n + 1)) & ~x &
+ (x & ~0UL / 255 * 127) + ~0UL / 255 * (127 - (m - 1))) &
probinson added inline comments.
Comment at: clang/lib/Basic/SourceManager.cpp:1255
-#ifdef __SSE2__
-#include
-#endif
+// Check if mutli-byte word x has bytes between m and n, included. This may
also
+// catch bytes equal to n + 1.
Typo: multi-byte. Also, I
On Wed, Apr 07, 2021 at 12:48:01PM +, Simon Pilgrim via Phabricator wrote:
> RKSimon added a comment.
>
> @serge-sans-paille Please can you look at the clang-ppc buildbot breakages:
> http://lab.llvm.org:8011/#/builders/52/builds/6108
I'm on it.
__
10 matches
Mail list logo