[PATCH] D99432: [OPENMP]Fix PR48851: the locals are not globalized in SPMD mode.

ABataev updated this revision to Diff 338107. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99432/new/ https://reviews.llvm.org/D99432 Files: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp clang/test/OpenMP/nvptx_dist

[PATCH] D99432: [OPENMP]Fix PR48851: the locals are not globalized in SPMD mode.

estewart08 added a comment. In reference to https://bugs.llvm.org/show_bug.cgi?id=48851, I do not see how this helps SPMD mode with team privatization of declarations in-between target teams and parallel regions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D99432: [OPENMP]Fix PR48851: the locals are not globalized in SPMD mode.

ABataev added a comment. In D99432#2726019 , @estewart08 wrote: > In reference to https://bugs.llvm.org/show_bug.cgi?id=48851, I do not see how > this helps SPMD mode with team privatization of declarations in-between > target teams and parallel regions.

[PATCH] D99432: [OPENMP]Fix PR48851: the locals are not globalized in SPMD mode.

estewart08 added a comment. In D99432#2726025 , @ABataev wrote: > In D99432#2726019 , @estewart08 > wrote: > >> In reference to https://bugs.llvm.org/show_bug.cgi?id=48851, I do not see >> how this helps SPMD mode

[PATCH] D99432: [OPENMP]Fix PR48851: the locals are not globalized in SPMD mode.

ABataev added a comment. In D99432#2726050 , @estewart08 wrote: > In D99432#2726025 , @ABataev wrote: > >> In D99432#2726019 , @estewart08 >> wrote: >> >>> In reference to h

[PATCH] D99432: [OPENMP]Fix PR48851: the locals are not globalized in SPMD mode.

estewart08 added a comment. In D99432#2726060 , @ABataev wrote: > In D99432#2726050 , @estewart08 > wrote: > >> In D99432#2726025 , @ABataev wrote: >> >>> In D99432#2726019

[PATCH] D99432: [OPENMP]Fix PR48851: the locals are not globalized in SPMD mode.

ABataev added a comment. In D99432#2726337 , @estewart08 wrote: > In D99432#2726060 , @ABataev wrote: > >> In D99432#2726050 , @estewart08 >> wrote: >> >>> In D99432#2726025

[PATCH] D99432: [OPENMP]Fix PR48851: the locals are not globalized in SPMD mode.

estewart08 added a comment. In D99432#2726391 , @ABataev wrote: > In D99432#2726337 , @estewart08 > wrote: > >> In D99432#2726060 , @ABataev wrote: >> >>> In D99432#2726050

[PATCH] D99432: [OPENMP]Fix PR48851: the locals are not globalized in SPMD mode.

ABataev added a comment. In D99432#2726588 , @estewart08 wrote: > In D99432#2726391 , @ABataev wrote: > >> In D99432#2726337 , @estewart08 >> wrote: >> >>> In D99432#2726060

[PATCH] D99432: [OPENMP]Fix PR48851: the locals are not globalized in SPMD mode.

estewart08 added a comment. In D99432#2726845 , @ABataev wrote: > In D99432#2726588 , @estewart08 > wrote: > >> In D99432#2726391 , @ABataev wrote: >> >>> In D99432#2726337

[PATCH] D99432: [OPENMP]Fix PR48851: the locals are not globalized in SPMD mode.

ABataev added a comment. In D99432#2726997 , @estewart08 wrote: > In D99432#2726845 , @ABataev wrote: > >> In D99432#2726588 , @estewart08 >> wrote: >> >>> In D99432#2726391

[PATCH] D99432: [OPENMP]Fix PR48851: the locals are not globalized in SPMD mode.

estewart08 added a comment. In D99432#2728788 , @ABataev wrote: > In D99432#2726997 , @estewart08 > wrote: > >> In D99432#2726845 , @ABataev wrote: >> >>> In D99432#2726588

[PATCH] D99432: [OPENMP]Fix PR48851: the locals are not globalized in SPMD mode.

ABataev added a comment. In D99432#2736970 , @estewart08 wrote: > In D99432#2728788 , @ABataev wrote: > >> In D99432#2726997 , @estewart08 >> wrote: >> >>> In D99432#2726845

[PATCH] D99432: [OPENMP]Fix PR48851: the locals are not globalized in SPMD mode.

estewart08 added a comment. In D99432#2736981 , @ABataev wrote: > In D99432#2736970 , @estewart08 > wrote: > >> In D99432#2728788 , @ABataev wrote: >> >>> In D99432#2726997

[PATCH] D99432: [OPENMP]Fix PR48851: the locals are not globalized in SPMD mode.

ABataev added a comment. In D99432#2738859 , @estewart08 wrote: > In D99432#2736981 , @ABataev wrote: > >> In D99432#2736970 , @estewart08 >> wrote: >> >>> In D99432#2728788

[PATCH] D99432: [OPENMP]Fix PR48851: the locals are not globalized in SPMD mode.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: guansong, yaxunl. ABataev requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. Need to perform general analysis on SPMD kernels to correctly identify the

[PATCH] D99432: [OPENMP]Fix PR48851: the locals are not globalized in SPMD mode.

jdoerfert added a comment. Can we please always do the globalization, even in the `target teams distribute parallel for` case you need it if a thread shares the address of a local variable with the team and another thread uses it. There is no argument other than "doesn't escape" that Clang can m

[PATCH] D99432: [OPENMP]Fix PR48851: the locals are not globalized in SPMD mode.

ABataev added a comment. In D99432#2653474 , @jdoerfert wrote: > Can we please always do the globalization, even in the `target teams > distribute parallel for` case you need it if a thread shares the address of a > local variable with the team and anoth

[PATCH] D99432: [OPENMP]Fix PR48851: the locals are not globalized in SPMD mode.

jdoerfert added a comment. In D99432#2653483 , @ABataev wrote: > In D99432#2653474 , @jdoerfert wrote: > >> Can we please always do the globalization, even in the `target teams >> distribute parallel for` case you

[PATCH] D99432: [OPENMP]Fix PR48851: the locals are not globalized in SPMD mode.

ABataev added a comment. In D99432#2654025 , @jdoerfert wrote: > In D99432#2653483 , @ABataev wrote: > >> In D99432#2653474 , @jdoerfert >> wrote: >> >>> Can we please alway