[PATCH] D99601: [-Wcompletion-handler] Don't recognize init methods as conventional

This revision was automatically updated to reflect the committed changes. vsavchenko marked an inline comment as done. Closed by commit rG77f1e096e8a0: [-Wcompletion-handler] Don't recognize init methods as conventional (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D99601: [-Wcompletion-handler] Don't recognize init methods as conventional

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Looks great now! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99601/new/ https://reviews.llvm.org/D99601 ___

[PATCH] D99601: [-Wcompletion-handler] Don't recognize init methods as conventional

vsavchenko marked an inline comment as done. vsavchenko added inline comments. Comment at: clang/lib/Analysis/CalledOnceCheck.cpp:1017 + static bool isInitMethod(Selector MethodSelector) { +return MethodSelector.getNameForSlot(0).startswith_lower(INIT_PREFIX); + } -

[PATCH] D99601: [-Wcompletion-handler] Don't recognize init methods as conventional

vsavchenko updated this revision to Diff 335462. vsavchenko added a comment. Use builtin way of checking for init methods Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99601/new/ https://reviews.llvm.org/D99601 Files: clang/lib/Analysis/CalledOn

[PATCH] D99601: [-Wcompletion-handler] Don't recognize init methods as conventional

NoQ added inline comments. Comment at: clang/lib/Analysis/CalledOnceCheck.cpp:1017 + static bool isInitMethod(Selector MethodSelector) { +return MethodSelector.getNameForSlot(0).startswith_lower(INIT_PREFIX); + } You can formally check whether it's an init

[PATCH] D99601: [-Wcompletion-handler] Don't recognize init methods as conventional

vsavchenko created this revision. vsavchenko added a reviewer: NoQ. Herald added a subscriber: Charusso. vsavchenko requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. rdar://75704162 Repository: rG LLVM Github Monorepo https://reviews.llv