[PATCH] D99645: [flang][driver] Add debug options not requiring semantic checks

walli99 added a comment. انت Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99645/new/ https://reviews.llvm.org/D99645 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[PATCH] D99645: [flang][driver] Add debug options not requiring semantic checks

awarzynski added a comment. In D99645#2674496 , @kiranchandramohan wrote: > LGTM. > > Might be good to have a test for fdebug-dump-parse-tree-no-sema. Good point, added before merging into main! Thank you for reviewing. Repository: rG LLVM Github Mon

[PATCH] D99645: [flang][driver] Add debug options not requiring semantic checks

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe81b3401177a: [flang][driver] Add debug options not requiring semantic checks (authored by awarzynski). Changed prior to commit: https://reviews.l

[PATCH] D99645: [flang][driver] Add debug options not requiring semantic checks

kiranchandramohan accepted this revision. kiranchandramohan added a comment. LGTM. Might be good to have a test for fdebug-dump-parse-tree-no-sema. Comment at: flang/include/flang/Frontend/FrontendOptions.h:54 + /// Parse, run semantics and then output the parse tree, skip

[PATCH] D99645: [flang][driver] Add debug options not requiring semantic checks

awarzynski added inline comments. Comment at: clang/include/clang/Driver/Options.td:4378 HelpText<"Run the InputOuputTest action. Use for development and testing only.">; +def fdebug_unparse_no_sema : Flag<["-"], "fdebug-unparse-no-sema">, Group, + HelpText<"Unparse and sto

[PATCH] D99645: [flang][driver] Add debug options not requiring semantic checks

awarzynski updated this revision to Diff 335820. awarzynski added a comment. Add DocBrief descriptions in Options.td I added the descriptions so that it's documented what the options are intended for and to avoid confusion in the future. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D99645: [flang][driver] Add debug options not requiring semantic checks

awarzynski added inline comments. Comment at: clang/include/clang/Driver/Options.td:4378 HelpText<"Run the InputOuputTest action. Use for development and testing only.">; +def fdebug_unparse_no_sema : Flag<["-"], "fdebug-unparse-no-sema">, Group, + HelpText<"Unparse and sto

[PATCH] D99645: [flang][driver] Add debug options not requiring semantic checks

kiranchandramohan added inline comments. Comment at: clang/include/clang/Driver/Options.td:4378 HelpText<"Run the InputOuputTest action. Use for development and testing only.">; +def fdebug_unparse_no_sema : Flag<["-"], "fdebug-unparse-no-sema">, Group, + HelpText<"Unparse

[PATCH] D99645: [flang][driver] Add debug options not requiring semantic checks

awarzynski added inline comments. Comment at: flang/lib/Frontend/FrontendActions.cpp:127 + + auto &parseTree{*ci.parsing().parseTree()}; + ashermancinelli wrote: > Is this variable unused? How did it get here? :) Thank you, updated! Repository: rG LLVM Githu

[PATCH] D99645: [flang][driver] Add debug options not requiring semantic checks

awarzynski updated this revision to Diff 335587. awarzynski added a comment. Remove unused variable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99645/new/ https://reviews.llvm.org/D99645 Files: clang/include/clang/Driver/Options.td flang/inc

[PATCH] D99645: [flang][driver] Add debug options not requiring semantic checks

awarzynski added inline comments. Comment at: flang/test/Parser/omp-allocate-unparse.f90:1 -! RUN: %f18 -fdebug-no-semantics -funparse -fopenmp %s | FileCheck %s +! RUN: %flang_fc1 -fdebug-unparse-no-sema -fopenmp %s | FileCheck %s ! Check Unparsing of OpenMP Allocate directive

[PATCH] D99645: [flang][driver] Add debug options not requiring semantic checks

ashermancinelli added inline comments. Comment at: flang/lib/Frontend/FrontendActions.cpp:127 + + auto &parseTree{*ci.parsing().parseTree()}; + Is this variable unused? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D99645: [flang][driver] Add debug options not requiring semantic checks

awarzynski updated this revision to Diff 335566. awarzynski added a comment. Update `f18.cpp` and driver-help.f90 to improve testing - added -fdebug-unparse-no-sema and -fdebug-dump-parse-tree-no-sema in f18.cpp (for compatibility with flang-new) - updated driver-help.f90 with the new options

[PATCH] D99645: [flang][driver] Add debug options not requiring semantic checks

arnamoy10 added inline comments. Comment at: flang/test/Parser/omp-allocate-unparse.f90:1 -! RUN: %f18 -fdebug-no-semantics -funparse -fopenmp %s | FileCheck %s +! RUN: %flang_fc1 -fdebug-unparse-no-sema -fopenmp %s | FileCheck %s ! Check Unparsing of OpenMP Allocate directive -

[PATCH] D99645: [flang][driver] Add debug options not requiring semantic checks

awarzynski created this revision. Herald added a reviewer: sscalpone. Herald added subscribers: jansvoboda11, dang. awarzynski requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patch adds two