[PATCH] D99683: [HIP] Support ThinLTO

This revision was automatically updated to reflect the committed changes. Closed by commit rGbf6124580dfb: [HIP] support ThinLTO (authored by yaxunl). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D99683?vs=344949&id=347205#toc Repository: rG LLVM Github Mon

[PATCH] D99683: [HIP] Support ThinLTO

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99683/new/ https://reviews.llvm.org/D99683 ___ cfe-commits mailing list cfe-commi

[PATCH] D99683: [HIP] Support ThinLTO

yaxunl updated this revision to Diff 344949. yaxunl marked an inline comment as done. yaxunl added a comment. Revised by Teresa's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99683/new/ https://reviews.llvm.org/D99683 Files: clang/include/clang/Driver/Driver.h clang/inclu

[PATCH] D99683: [HIP] Support ThinLTO

yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: llvm/lib/Transforms/IPO/FunctionImport.cpp:496 dbgs() << "ignored! No qualifying callee with summary found.\n"); continue; } tejohnson wrote: > yaxunl

[PATCH] D99683: [HIP] Support ThinLTO

tejohnson added inline comments. Comment at: llvm/lib/Transforms/IPO/FunctionImport.cpp:496 dbgs() << "ignored! No qualifying callee with summary found.\n"); continue; } yaxunl wrote: > tejohnson wrote: > > Probably better to issue an

[PATCH] D99683: [HIP] Support ThinLTO

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: llvm/lib/Transforms/IPO/FunctionImport.cpp:496 dbgs() << "ignored! No qualifying callee with summary found.\n"); continue; } tejohnson wrote: > Probabl

[PATCH] D99683: [HIP] Support ThinLTO

tejohnson added a comment. In D99683#2744764 , @yaxunl wrote: > In D99683#2683308 , @tejohnson wrote: > >> To do what I suggested in the prior comment, you'd probably want to add a >> new index-wide flag (since we

[PATCH] D99683: [HIP] Support ThinLTO

yaxunl updated this revision to Diff 343696. yaxunl marked an inline comment as done. yaxunl added a comment. revised by Teresa's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99683/new/ https://reviews.llvm.org/D99683 Files: clang/include/clang/Driver/Driver.h clang/inclu

[PATCH] D99683: [HIP] Support ThinLTO

yaxunl marked an inline comment as done. yaxunl added a comment. In D99683#2683308 , @tejohnson wrote: > To do what I suggested in the prior comment, you'd probably want to add a new > index-wide flag (since we don't read IR in the thin link). See for exa

[PATCH] D99683: [HIP] Support ThinLTO

tejohnson requested changes to this revision. tejohnson added a comment. This revision now requires changes to proceed. To do what I suggested in the prior comment, you'd probably want to add a new index-wide flag (since we don't read IR in the thin link). See for example how EnableSplitLTOUnit

[PATCH] D99683: [HIP] Support ThinLTO

tejohnson added a comment. In D99683#2677357 , @yaxunl wrote: > Any other concerns? Thanks. I have some concerns around the fragility of this, for the reasons I mentioned earlier where it may not always be able to import everything needed. > We will doc

[PATCH] D99683: [HIP] Support ThinLTO

yaxunl added a comment. Any other concerns? Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99683/new/ https://reviews.llvm.org/D99683 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[PATCH] D99683: [HIP] Support ThinLTO

yaxunl added a comment. In D99683#2672668 , @tejohnson wrote: > In D99683#2672578 , @yaxunl wrote: > >> In D99683#2672554 , @tejohnson >> wrote: >> >>> This raises some high

[PATCH] D99683: [HIP] Support ThinLTO

tejohnson added a comment. In D99683#2672578 , @yaxunl wrote: > In D99683#2672554 , @tejohnson wrote: > >> This raises some higher level questions for me: >> >> First, how will you deal with other corner cases that

[PATCH] D99683: [HIP] Support ThinLTO

yaxunl added a comment. In D99683#2672554 , @tejohnson wrote: > This raises some higher level questions for me: > > First, how will you deal with other corner cases that won't or cannot be > imported right now? While enabling importing of noinline functio

[PATCH] D99683: [HIP] Support ThinLTO

tejohnson added a comment. In D99683#2671727 , @yaxunl wrote: > In D99683#2669136 , @yaxunl wrote: > >> In D99683#2669080 , @tejohnson >> wrote: >> >>> In D99683#2669047

[PATCH] D99683: [HIP] Support ThinLTO

tra added inline comments. Comment at: clang/include/clang/Driver/Options.td:1904-1907 +def foffload_lto : Flag<["-"], "foffload-lto">, Flags<[CoreOption]>, Group, + HelpText<"Enable LTO in 'full' mode for offload compilation">; +def fno_offload_lto : Flag<["-"], "fno-offload-l

[PATCH] D99683: [HIP] Support ThinLTO

yaxunl updated this revision to Diff 335573. yaxunl added a comment. rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99683/new/ https://reviews.llvm.org/D99683 Files: clang/include/clang/Driver/Driver.h clang/include/clang/Driver/Options.td clang/lib/Driver/Driver.cpp clan

[PATCH] D99683: [HIP] Support ThinLTO

yaxunl updated this revision to Diff 335571. yaxunl marked an inline comment as done. yaxunl added a comment. revert the change about option CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99683/new/ https://reviews.llvm.org/D99683 Files: clang/include/clang/Driver/Driver.h clang/inc

[PATCH] D99683: [HIP] Support ThinLTO

yaxunl marked an inline comment as done. yaxunl added a comment. In D99683#2669136 , @yaxunl wrote: > In D99683#2669080 , @tejohnson wrote: > >> In D99683#2669047 , @yaxunl w

[PATCH] D99683: [HIP] Support ThinLTO

jansvoboda11 added inline comments. Comment at: clang/include/clang/Driver/Options.td:1904-1907 +def foffload_lto : Flag<["-"], "foffload-lto">, Flags<[CoreOption]>, Group, + HelpText<"Enable LTO in 'full' mode for offload compilation">; +def fno_offload_lto : Flag<["-"], "fno-

[PATCH] D99683: [HIP] Support ThinLTO

yaxunl added a comment. In D99683#2669080 , @tejohnson wrote: > In D99683#2669047 , @yaxunl wrote: > >> In D99683#2664674 , @tejohnson >> wrote: >> >>> I haven't looked exte

[PATCH] D99683: [HIP] Support ThinLTO

yaxunl updated this revision to Diff 335268. yaxunl marked 4 inline comments as done. yaxunl edited the summary of this revision. yaxunl added a comment. Herald added a subscriber: tpr. Revise by Artem's comments. Add patch description. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99683

[PATCH] D99683: [HIP] Support ThinLTO

tejohnson added a comment. In D99683#2669047 , @yaxunl wrote: > In D99683#2664674 , @tejohnson wrote: > >> I haven't looked extensively yet, but why import noinline functions? Also, >> please add a patch descriptio

[PATCH] D99683: [HIP] Support ThinLTO

yaxunl marked 4 inline comments as done. yaxunl added a comment. In D99683#2664674 , @tejohnson wrote: > I haven't looked extensively yet, but why import noinline functions? Also, > please add a patch description. AMDGPU backend does not support linking

[PATCH] D99683: [HIP] Support ThinLTO

tejohnson added a comment. I haven't looked extensively yet, but why import noinline functions? Also, please add a patch description. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99683/new/ https://reviews.llvm.org/D99683 ___ cfe-commits ma

[PATCH] D99683: [HIP] Support ThinLTO

tra accepted this revision. tra added a subscriber: tejohnson. tra added a comment. This revision is now accepted and ready to land. LGTM in general. Please give LTO folks some time to chime in case they have any feedback. @tejohnson: Just a FYI that we're tinkering with LTO on GPUs here. ===

[PATCH] D99683: [HIP] Support ThinLTO

yaxunl created this revision. yaxunl added reviewers: tra, ashi1, scchan. Herald added subscribers: jansvoboda11, dang, hiraditya, inglorion. yaxunl requested review of this revision. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. https://reviews.llvm.org/D99683 Files: c