[PATCH] D99934: [clang][Syntax] Handle invalid source range in expandedTokens.

2021-04-07 Thread Utkarsh Saxena via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcd824a48cccb: [clang][Syntax] Handle invalid source range in expandedTokens. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D99934: [clang][Syntax] Handle invalid source range in expandedTokens.

2021-04-07 Thread Utkarsh Saxena via Phabricator via cfe-commits
usaxena95 added a comment. Clangd was seen to be crashing on Objective C/C++ files. It could not be reproduced but inspection of coredump showed that the `expandedTokens` returned arrayref with begin > end (negative length). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D99934: [clang][Syntax] Handle invalid source range in expandedTokens.

2021-04-06 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. (Do we have a bug this fixes?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99934/new/ https://reviews.llvm.org/D99934 _

[PATCH] D99934: [clang][Syntax] Handle invalid source range in expandedTokens.

2021-04-06 Thread Utkarsh Saxena via Phabricator via cfe-commits
usaxena95 created this revision. usaxena95 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. sammccall Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D99934 Files: clang/lib/Tooling/Syntax/Tokens.cpp Index: clang/lib/T