https://github.com/jkorous-apple closed
https://github.com/llvm/llvm-project/pull/81343
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/haoNoQ approved this pull request.
LGTM let's land!
https://github.com/llvm/llvm-project/pull/81343
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jkorous-apple updated
https://github.com/llvm/llvm-project/pull/81343
>From 791130c5c5de31084c168db33531a5d856104506 Mon Sep 17 00:00:00 2001
From: Jan Korous
Date: Thu, 8 Feb 2024 14:30:20 -0800
Subject: [PATCH 1/5] [-Wunsafe-buffer-usage][NFC] Factor out .data() fixit to
https://github.com/haoNoQ commented:
LGTM! I have a couple minor nitpicks.
https://github.com/llvm/llvm-project/pull/81343
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,43 @@
+// RUN: %clang_cc1 -std=c++20 -Wunsafe-buffer-usage \
+// RUN:-fsafe-buffer-usage-suggestions \
+// RUN:-fdiagnostics-parseable-fixits %s 2>&1 | FileCheck %s
+
+void safe_array_assigned_to_safe_ptr(unsigned idx) {
+ int buffer[10];
+ //
@@ -1490,6 +1548,26 @@ PointerAssignmentGadget::getFixits(const FixitStrategy
) const {
return std::nullopt;
}
+/// \returns fixit that adds .data() call after \DRE.
+static inline std::optional createDataFixit(const ASTContext ,
+
@@ -848,6 +852,60 @@ class PointerAssignmentGadget : public FixableGadget {
}
};
+/// An assignment expression of the form:
+/// \code
+/// ptr = array;
+/// \endcode
+/// where `p` is a pointer and `array` is a constant size array.
+class CArrayToPtrAssignmentGadget :
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (jkorous-apple)
Changes
depends on
https://github.com/llvm/llvm-project/pull/80347
---
Full diff: https://github.com/llvm/llvm-project/pull/81343.diff
4 Files Affected:
- (modified)
https://github.com/jkorous-apple updated
https://github.com/llvm/llvm-project/pull/81343
>From 791130c5c5de31084c168db33531a5d856104506 Mon Sep 17 00:00:00 2001
From: Jan Korous
Date: Thu, 8 Feb 2024 14:30:20 -0800
Subject: [PATCH 1/4] [-Wunsafe-buffer-usage][NFC] Factor out .data() fixit to
https://github.com/jkorous-apple updated
https://github.com/llvm/llvm-project/pull/81343
>From dfc9d95c185f5228f5c9680a19aa396d20e33d19 Mon Sep 17 00:00:00 2001
From: Jan Korous
Date: Thu, 25 Jan 2024 13:52:12 -0800
Subject: [PATCH 01/11] [-Wunsafe-buffer-usage] Emit fixits for arguments of
https://github.com/jkorous-apple updated
https://github.com/llvm/llvm-project/pull/81343
>From dfc9d95c185f5228f5c9680a19aa396d20e33d19 Mon Sep 17 00:00:00 2001
From: Jan Korous
Date: Thu, 25 Jan 2024 13:52:12 -0800
Subject: [PATCH 01/10] [-Wunsafe-buffer-usage] Emit fixits for arguments of
https://github.com/jkorous-apple ready_for_review
https://github.com/llvm/llvm-project/pull/81343
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jkorous-apple converted_to_draft
https://github.com/llvm/llvm-project/pull/81343
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 86cd2fbdfe67d70a7fe061ed5d3a644f50f070f5
47c18be02329b853513d0955b8443e3bd4f04778 --
14 matches
Mail list logo
