davemgreen wrote:
The way we tried to mitigate this in the past was to use
-target=aarch64-arm-none-eabi for our downstream compiler, and have downstream
differences gated on the arm vendor. It can help keep the upstream tests the
same if they use -target=aarch64-unknown-linux-gnu, and have do
madhur13490 wrote:
Thanks all. Abandoning this change, will find an appropriate solution for
downstream.
https://github.com/llvm/llvm-project/pull/134338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/li
https://github.com/madhur13490 closed
https://github.com/llvm/llvm-project/pull/134338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaskRay requested changes to this pull request.
.
https://github.com/llvm/llvm-project/pull/134338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MaskRay wrote:
The -NEXT unexpected macros. Please address this by modifying your downstream
target. This is a downstream maintenance task, and it's important to avoid
reducing the quality of upstream testing.
https://github.com/llvm/llvm-project/pull/134338
___
SpencerAbson wrote:
Agree with @arsenm.
If you'd rather not `XFAIL` (or equivalent) this file in your downstream CI,
perhaps you could have it autogenerated. A colleague of mine once wrote a
script to do something similar
https://github.com/llvm/llvm-project/pull/97829#issuecomment-221353566
madhur13490 wrote:
> The other tests should be strengthened to always use -NEXT. The exact set of
> macros should be tested; don't want others hiding in the gaps
Thanks, @arsenm. However, the strict checks are creating problems in our
downstream compiler and rebasing. Our downstream compiler e
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Madhur Amilkanthwar (madhur13490)
Changes
The checks in init-aarch64.c expect macros to be back-to-back which seems very
strict. This change aims to relax this and use just AARCH64 instead of
AARCH64-NEXT. This way, we maintain the order
https://github.com/arsenm requested changes to this pull request.
The other tests should be strengthened to always use -NEXT. The exact set of
macros should be tested, don't want others hiding in the gaps
https://github.com/llvm/llvm-project/pull/134338
https://github.com/madhur13490 created
https://github.com/llvm/llvm-project/pull/134338
The checks in init-aarch64.c expect macros to be back-to-back which seems very
strict. This change aims to relax this and use just AARCH64 instead of
AARCH64-NEXT. This way, we maintain the order of the mac
10 matches
Mail list logo
