https://github.com/hstk30-hw closed
https://github.com/llvm/llvm-project/pull/75440
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vhscampos approved this pull request.
LGTM. Thanks
https://github.com/llvm/llvm-project/pull/75440
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hstk30-hw wrote:
> There are some typos in the commit message and in the PR title.
@vhscampos Check again. Fixed the typos.
https://github.com/llvm/llvm-project/pull/75440
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/davemgreen approved this pull request.
Thanks. LGTM
https://github.com/llvm/llvm-project/pull/75440
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/hstk30-hw updated
https://github.com/llvm/llvm-project/pull/75440
>From ee562f7e8e8577ee93631a8425efd80e7ce64c18 Mon Sep 17 00:00:00 2001
From: hstk30-hw
Date: Thu, 14 Dec 2023 15:40:03 +0800
Subject: [PATCH] feat: arm_acle.h add Coprocessor Instrinsics
---
davemgreen wrote:
If you can make armv9-a work the same as armv8-a and add some tests for it then
this LGTM
https://github.com/llvm/llvm-project/pull/75440
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -836,6 +837,70 @@ void ARMTargetInfo::getTargetDefines(const LangOptions
,
if (Opts.RWPI)
Builder.defineMacro("__ARM_RWPI", "1");
+ // Macros for enabling co-proc intrinsics
+ uint64_t FeatureCoprocBF = 0;
+ switch (ArchKind) {
+ default:
+break;
+ case
@@ -836,6 +837,70 @@ void ARMTargetInfo::getTargetDefines(const LangOptions
,
if (Opts.RWPI)
Builder.defineMacro("__ARM_RWPI", "1");
+ // Macros for enabling co-proc intrinsics
+ uint64_t FeatureCoprocBF = 0;
+ switch (ArchKind) {
+ default:
+break;
+ case
@@ -836,6 +837,70 @@ void ARMTargetInfo::getTargetDefines(const LangOptions
,
if (Opts.RWPI)
Builder.defineMacro("__ARM_RWPI", "1");
+ // Macros for enabling co-proc intrinsics
+ uint64_t FeatureCoprocBF = 0;
+ switch (ArchKind) {
+ default:
+break;
+ case
https://github.com/hstk30-hw updated
https://github.com/llvm/llvm-project/pull/75440
>From 18af0ae248707b7c33b24065cdbab5399337f8bc Mon Sep 17 00:00:00 2001
From: hstk30-hw
Date: Thu, 14 Dec 2023 15:40:03 +0800
Subject: [PATCH] feat: arm_acle.h add Coprocessor Instrinsics
---
https://github.com/davemgreen edited
https://github.com/llvm/llvm-project/pull/75440
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -756,6 +756,58 @@ __arm_st64bv0(void *__addr, data512_t __value) {
__builtin_arm_mops_memset_tag(__tagged_address, __value, __size)
#endif
+/* Coprocessor Intrinsics */
+#if defined(__ARM_FEATURE_COPROC)
+
+#if (__ARM_FEATURE_COPROC & 0x1)
+
+#if (__ARM_ARCH != 8)
@@ -836,6 +837,70 @@ void ARMTargetInfo::getTargetDefines(const LangOptions
,
if (Opts.RWPI)
Builder.defineMacro("__ARM_RWPI", "1");
+ // Macros for enabling co-proc intrinsics
+ uint64_t FeatureCoprocBF = 0;
+ switch (ArchKind) {
+ default:
+break;
+ case
@@ -836,6 +837,70 @@ void ARMTargetInfo::getTargetDefines(const LangOptions
,
if (Opts.RWPI)
Builder.defineMacro("__ARM_RWPI", "1");
+ // Macros for enabling co-proc intrinsics
+ uint64_t FeatureCoprocBF = 0;
+ switch (ArchKind) {
+ default:
+break;
+ case
https://github.com/davemgreen commented:
Thanks. This is looking good to me. I just have a few comments about different
architecture revisions.
https://github.com/llvm/llvm-project/pull/75440
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/hstk30-hw updated
https://github.com/llvm/llvm-project/pull/75440
>From ce9db667e6567532fe119ff8d793281215f223dc Mon Sep 17 00:00:00 2001
From: hstk30-hw
Date: Thu, 14 Dec 2023 15:40:03 +0800
Subject: [PATCH] feat: arm_acle.h add Coprocessor Instrinsics
---
hstk30-hw wrote:
Use bitfield still a mess up because the different arm version have different
Instrinsics available even in the same bit group.
I will try it, hope it readable.
https://github.com/llvm/llvm-project/pull/75440
___
cfe-commits mailing
@@ -0,0 +1,346 @@
+// RUN: %clang_cc1 -triple armv4 %s -E -dD -o - | FileCheck
--check-prefix=CHECK-V4 %s
+// RUN: %clang_cc1 -triple armv4t %s -E -dD -o - | FileCheck
--check-prefix=CHECK-V4 %s
+// RUN: %clang_cc1 -triple armv5 %s -E -dD -o - | FileCheck
https://github.com/hstk30-hw deleted
https://github.com/llvm/llvm-project/pull/75440
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,346 @@
+// RUN: %clang_cc1 -triple armv4 %s -E -dD -o - | FileCheck
--check-prefix=CHECK-V4 %s
+// RUN: %clang_cc1 -triple armv4t %s -E -dD -o - | FileCheck
--check-prefix=CHECK-V4 %s
+// RUN: %clang_cc1 -triple armv5 %s -E -dD -o - | FileCheck
davemgreen wrote:
Thanks for doing this.
I think that __ARM_FEATURE_COPROC should be a bitfield, as defined in
https://arm-software.github.io/acle/main/acle.html#coprocessor-intrinsics. That
would remove the need for the other macros.
https://github.com/llvm/llvm-project/pull/75440
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 88d319a29ff5d3be1bb9a7e88ef6e17df1dfe607
5a746e97989ba795264d20aef4f056db0c17bc2c --
https://github.com/hstk30-hw updated
https://github.com/llvm/llvm-project/pull/75440
>From 5a746e97989ba795264d20aef4f056db0c17bc2c Mon Sep 17 00:00:00 2001
From: hstk30-hw
Date: Thu, 14 Dec 2023 15:40:03 +0800
Subject: [PATCH] feat: arm_acle.h add Coprocessor Instrinsics
---
davemgreen wrote:
This is the downstream code we have:
https://gist.github.com/davemgreen/e7ade833274a60e975e67a66eda7cb44
Note that the __ARM_TARGET_COPROC_XYZ macros are probably wrong. They should be
__ARM_FEATURE_COPROC bitfield macros according to the ACLE.
Can you make use of some of
davemgreen wrote:
Let me try and get the downstream version, you might be able to pick up some
things from it. A test at least should probably be present.
https://github.com/llvm/llvm-project/pull/75440
___
cfe-commits mailing list
hstk30-hw wrote:
I follow the gcc arm_acle.h
https://github.com/gcc-mirror/gcc/blob/144c531fe25483b65ad3189d7b5e9f78154477c2/gcc/config/arm/arm_acle.h#L99C1-L239C1
code. And check the doc https://developer.arm.com/documentation/101028/latest/ .
I think It's ok to merge it.
Check it plz.
https://github.com/hstk30-hw edited
https://github.com/llvm/llvm-project/pull/75440
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
davemgreen wrote:
It looks like there is a downstream implementation of this that was never
upstreamed. Perhaps someone can fish it out for you to show how it looked? It
might be using the wrong predefined macro, but does have some tests.
https://github.com/llvm/llvm-project/pull/75440
https://github.com/hstk30-hw updated
https://github.com/llvm/llvm-project/pull/75440
>From fdb2b45298ef5282897297c913a195af07aec64b Mon Sep 17 00:00:00 2001
From: hstk30-hw
Date: Thu, 14 Dec 2023 15:40:03 +0800
Subject: [PATCH] feat: arm_acle.h add Coprocessor Instrinsics
---
https://github.com/hstk30-hw edited
https://github.com/llvm/llvm-project/pull/75440
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
30 matches
Mail list logo
