https://github.com/ChuanqiXu9 created
https://github.com/llvm/llvm-project/pull/67638
Close https://github.com/llvm/llvm-project/issues/56794
And see https://github.com/llvm/llvm-project/issues/67582 for a detailed
backgrond for the issue.
As required by the Itanium ABI, the module units ha
llvmbot wrote:
@llvm/pr-subscribers-clang-modules
Changes
Close https://github.com/llvm/llvm-project/issues/56794
And see https://github.com/llvm/llvm-project/issues/67582 for a detailed
backgrond for the issue.
As required by the Itanium ABI, the module units have to generate the
ini
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 0e8a8c85f8765c086c573f36e60c895920381e18
2448304b847da467a2a81c33daa7fb789948edf1 --
https://github.com/ChuanqiXu9 updated
https://github.com/llvm/llvm-project/pull/67638
>From 51c53a1aaed8fef470e699513a0f44187fbb623d Mon Sep 17 00:00:00 2001
From: Chuanqi Xu
Date: Thu, 28 Sep 2023 15:32:31 +0800
Subject: [PATCH] [C++20] [Modules] Don't generate call to an imported module
that
https://github.com/iains commented:
Thanks for working on this.
Generally, this LGTM, but perhaps we can choose names that are unambiguously
related to state - the current one could be read like an action.
maybe something like:
`NamedModuleHasNoInit`
and
`namedModuleHasNoInit()`
(or I'm open
ChuanqiXu9 wrote:
Opinions addressed.
https://github.com/llvm/llvm-project/pull/67638
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ChuanqiXu9 updated
https://github.com/llvm/llvm-project/pull/67638
>From 02b65f03b80470078107194fc1ce28680b804dab Mon Sep 17 00:00:00 2001
From: Chuanqi Xu
Date: Thu, 28 Sep 2023 15:32:31 +0800
Subject: [PATCH] [C++20] [Modules] Don't generate call to an imported module
that
https://github.com/iains approved this pull request.
thanks, LGTM
https://github.com/llvm/llvm-project/pull/67638
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ChuanqiXu9 closed
https://github.com/llvm/llvm-project/pull/67638
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1245,6 +1245,27 @@ void Sema::ActOnEndOfTranslationUnit() {
}
}
+// Now we can decide whether the modules we're building need an
initializer.
+if (Module *CurrentModule = getCurrentModule();
+CurrentModule && CurrentModule->isInterfaceOrPartition
@@ -1245,6 +1245,27 @@ void Sema::ActOnEndOfTranslationUnit() {
}
}
+// Now we can decide whether the modules we're building need an
initializer.
+if (Module *CurrentModule = getCurrentModule();
+CurrentModule && CurrentModule->isInterfaceOrPartition
11 matches
Mail list logo