[clang] [C++20] [Modules] Don't import function bodies from other module units even with optimizations (PR #71031)

ChuanqiXu9 wrote: Sorry for being too hurry here. https://github.com/llvm/llvm-project/pull/71031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C++20] [Modules] Don't import function bodies from other module units even with optimizations (PR #71031)

dwblaikie wrote: Please don't commit changes that have been sent for review, but have not been reviewed. https://github.com/llvm/llvm-project/pull/71031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [C++20] [Modules] Don't import function bodies from other module units even with optimizations (PR #71031)

https://github.com/ChuanqiXu9 closed https://github.com/llvm/llvm-project/pull/71031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C++20] [Modules] Don't import function bodies from other module units even with optimizations (PR #71031)

https://github.com/ChuanqiXu9 updated https://github.com/llvm/llvm-project/pull/71031 >From 82173f3556d40fc1c6e106820ad281b928a2c7fe Mon Sep 17 00:00:00 2001 From: Chuanqi Xu Date: Thu, 2 Nov 2023 15:19:58 +0800 Subject: [PATCH] [C++20] [Modules] Don't import function bodies from other module

[clang] [C++20] [Modules] Don't import function bodies from other module units even with optimizations (PR #71031)

https://github.com/ChuanqiXu9 updated https://github.com/llvm/llvm-project/pull/71031 >From 427c1e1960d48e8803e235b4d5beb437ea21c942 Mon Sep 17 00:00:00 2001 From: Chuanqi Xu Date: Thu, 2 Nov 2023 15:19:58 +0800 Subject: [PATCH 1/2] [C++20] [Modules] Don't import function bodies from other

[clang] [C++20] [Modules] Don't import function bodies from other module units even with optimizations (PR #71031)

ChuanqiXu9 wrote: I'd like to land this change later since the existing behavior violates our expectations for ABI. https://github.com/llvm/llvm-project/pull/71031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [C++20] [Modules] Don't import function bodies from other module units even with optimizations (PR #71031)

@@ -3856,10 +3856,19 @@ CodeGenModule::isTriviallyRecursive(const FunctionDecl *FD) { bool CodeGenModule::shouldEmitFunction(GlobalDecl GD) { if (getFunctionLinkage(GD) != llvm::Function::AvailableExternallyLinkage) return true; + const auto *F = cast(GD.getDecl());

[clang] [C++20] [Modules] Don't import function bodies from other module units even with optimizations (PR #71031)

@@ -3856,10 +3856,19 @@ CodeGenModule::isTriviallyRecursive(const FunctionDecl *FD) { bool CodeGenModule::shouldEmitFunction(GlobalDecl GD) { if (getFunctionLinkage(GD) != llvm::Function::AvailableExternallyLinkage) return true; + const auto *F = cast(GD.getDecl());

[clang] [C++20] [Modules] Don't import function bodies from other module units even with optimizations (PR #71031)

llvmbot wrote: @llvm/pr-subscribers-clang-modules Author: Chuanqi Xu (ChuanqiXu9) Changes Close https://github.com/llvm/llvm-project/issues/60996. Previously, clang will try to import function bodies from other module units to get more optimization oppotunities as much as possible. Then

[clang] [C++20] [Modules] Don't import function bodies from other module units even with optimizations (PR #71031)

https://github.com/ChuanqiXu9 created https://github.com/llvm/llvm-project/pull/71031 Close https://github.com/llvm/llvm-project/issues/60996. Previously, clang will try to import function bodies from other module units to get more optimization oppotunities as much as possible. Then the