https://github.com/andykaylor closed
https://github.com/llvm/llvm-project/pull/140425
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/andykaylor approved this pull request.
lgtm
https://github.com/llvm/llvm-project/pull/140425
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Andres-Salamanca updated
https://github.com/llvm/llvm-project/pull/140425
>From 384ec2904b91cbed8757720373b451389f5f1a1a Mon Sep 17 00:00:00 2001
From: Andres Salamanca
Date: Sat, 17 May 2025 19:36:05 -0500
Subject: [PATCH 1/2] Added lowering logic for switch and appropriate
https://github.com/bcardosolopes approved this pull request.
LGTM after you address Andy's nits.
https://github.com/llvm/llvm-project/pull/140425
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cf
@@ -1038,6 +1038,37 @@ mlir::LogicalResult
CIRToLLVMGlobalOpLowering::matchAndRewrite(
return mlir::success();
}
+mlir::LogicalResult CIRToLLVMSwitchFlatOpLowering::matchAndRewrite(
+cir::SwitchFlatOp op, OpAdaptor adaptor,
+mlir::ConversionPatternRewriter &rewriter
https://github.com/andykaylor commented:
Looks good. Just a few nits.
https://github.com/llvm/llvm-project/pull/140425
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1038,6 +1038,37 @@ mlir::LogicalResult
CIRToLLVMGlobalOpLowering::matchAndRewrite(
return mlir::success();
}
+mlir::LogicalResult CIRToLLVMSwitchFlatOpLowering::matchAndRewrite(
+cir::SwitchFlatOp op, OpAdaptor adaptor,
+mlir::ConversionPatternRewriter &rewriter
https://github.com/andykaylor edited
https://github.com/llvm/llvm-project/pull/140425
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1038,6 +1038,37 @@ mlir::LogicalResult
CIRToLLVMGlobalOpLowering::matchAndRewrite(
return mlir::success();
}
+mlir::LogicalResult CIRToLLVMSwitchFlatOpLowering::matchAndRewrite(
+cir::SwitchFlatOp op, OpAdaptor adaptor,
+mlir::ConversionPatternRewriter &rewriter
@@ -1038,6 +1038,37 @@ mlir::LogicalResult
CIRToLLVMGlobalOpLowering::matchAndRewrite(
return mlir::success();
}
+mlir::LogicalResult CIRToLLVMSwitchFlatOpLowering::matchAndRewrite(
+cir::SwitchFlatOp op, OpAdaptor adaptor,
+mlir::ConversionPatternRewriter &rewriter
Andres-Salamanca wrote:
@andykaylor
https://github.com/llvm/llvm-project/pull/140425
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clangir
Author: None (Andres-Salamanca)
Changes
This PR adds support for lowering the `cir.switch` operation to LLVM. It
includes tests for lowering from `.cir` as well as end-to-end source code tests.
---
Patch is 26.83 KiB, truncated to 20.00 KiB be
https://github.com/Andres-Salamanca created
https://github.com/llvm/llvm-project/pull/140425
This PR adds support for lowering the `cir.switch` operation to LLVM. It
includes tests for lowering from `.cir` as well as end-to-end source code tests.
>From 384ec2904b91cbed8757720373b451389f5f1a1a
13 matches
Mail list logo